#2380: Add task measurements using linux perf #2381

pierrepebay · 2024-12-13T12:24:31Z

This contains the work done in #2304 with only the Linux Perf component.

github-actions · 2024-12-13T13:29:45Z

Pipelines results

PR tests (clang-13, alpine, mpich)

Build for 92ea7ec (2025-02-05 15:23:41 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-10, ubuntu, openmpi, no LB)

Build for 92ea7ec (2025-02-05 15:23:41 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-9, ubuntu, mpich)

Build for 92ea7ec (2025-02-05 15:23:41 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-9, ubuntu, mpich, zoltan)

Build for 92ea7ec (2025-02-05 15:23:41 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-12, ubuntu, mpich)

Build for 92ea7ec (2025-02-05 15:23:41 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-13, ubuntu, mpich)

Build for 92ea7ec (2025-02-05 15:23:41 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-14, ubuntu, mpich, verbose)

Build for 92ea7ec (2025-02-05 15:23:41 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-11, ubuntu, mpich)

Build for 92ea7ec (2025-02-05 15:23:41 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-10, ubuntu, mpich)

Build for 92ea7ec (2025-02-05 15:23:41 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-11, ubuntu, mpich, trace runtime, coverage)

Build for 92ea7ec (2025-02-05 15:23:41 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (intel icpx, ubuntu, mpich, verbose)

Build for 92ea7ec (2025-02-05 15:23:41 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (nvidia cuda 12.2.0, gcc-9, ubuntu, mpich, verbose)

Build for 92ea7ec (2025-02-05 15:23:41 UTC)

/vt/lib/CLI/CLI/CLI11.hpp(1029): warning #2361-D: invalid narrowing conversion from "double" to "unsigned long"
          TT { std::declval<CC>() }
               ^
          detected during:
            instantiation of "vt::CLI::detail::is_direct_constructible<T, C>::test [with T=std::vector<std::string, std::allocator<std::string>>, C=double]" based on template arguments <std::vector<std::string, std::allocator<std::string>>, double> at line 1041
            instantiation of class "vt::CLI::detail::is_direct_constructible<T, C> [with T=std::vector<std::string, std::allocator<std::string>>, C=double]" at line 5005
            instantiation of "void vt::CLI::Option::results(T &) const [with T=std::vector<std::string, std::allocator<std::string>>]" at line 5034
            instantiation of "T vt::CLI::Option::as<T>() const [with T=std::vector<std::string, std::allocator<std::string>>]" at line 7315

Remark: The warnings can be suppressed with "-diag-suppress <warning-number>"

/vt/lib/CLI/CLI/CLI11.hpp(1029): warning #2361-D: invalid narrowing conversion from "int" to "unsigned long"
          TT { std::declval<CC>() }
               ^
          detected during:
            instantiation of "vt::CLI::detail::is_direct_constructible<T, C>::test [with T=std::vector<std::string, std::allocator<std::string>>, C=int]" based on template arguments <std::vector<std::string, std::allocator<std::string>>, int> at line 1041
            instantiation of class "vt::CLI::detail::is_direct_constructible<T, C> [with T=std::vector<std::string, std::allocator<std::string>>, C=int]" at line 5005
            instantiation of "void vt::CLI::Option::results(T &) const [with T=std::vector<std::string, std::allocator<std::string>>]" at line 5034
            instantiation of "T vt::CLI::Option::as<T>() const [with T=std::vector<std::string, std::allocator<std::string>>]" at line 7315

Testing - passed

Build log

PR tests (gcc-12, ubuntu, mpich, verbose, kokkos)

Build for 92ea7ec (2025-02-05 15:23:41 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (nvidia cuda 11.2, gcc-9, ubuntu, mpich)

Build for 92ea7ec (2025-02-05 15:23:41 UTC)

/vt/src/vt/pipe/pipe_manager.impl.h(135): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&vt::vrt::collection::lb::GreedyLB::collectHandler, Target=vt::objgroup::proxy::ProxyElm<vt::vrt::collection::lb::GreedyLB>]"
          detected during:
            instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&vt::vrt::collection::lb::GreedyLB::collectHandler, Target=vt::objgroup::proxy::ProxyElm<vt::vrt::collection::lb::GreedyLB>]" 
/vt/src/vt/objgroup/proxy/proxy_objgroup.impl.h(221): here
            instantiation of "vt::objgroup::proxy::Proxy<ObjT>::PendingSendType vt::objgroup::proxy::Proxy<ObjT>::reduce<f,Op,Target,Args...>(Target, Args &&...) const [with ObjT=vt::vrt::collection::lb::GreedyLB, f=&vt::vrt::collection::lb::GreedyLB::collectHandler, Op=vt::collective::PlusOp, Target=vt::objgroup::proxy::ProxyElm<vt::vrt::collection::lb::GreedyLB>, Args=<vt::vrt::collection::lb::GreedyPayload>]" 
/vt/src/vt/vrt/collection/balance/greedylb/greedylb.cc(222): here

/vt/src/vt/pipe/pipe_manager.impl.h(135): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&MyObj::handler, Target=vt::objgroup::proxy::ProxyElm<MyObj>]"
          detected during instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&MyObj::handler, Target=vt::objgroup::proxy::ProxyElm<MyObj>]" 
/vt/examples/callback/callback.cc(147): here

/vt/src/vt/pipe/pipe_manager.impl.h(135): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&colHan, Target=vt::vrt::collection::VrtElmProxy<MyCol, vt::Index1D>]"
          detected during instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&colHan, Target=vt::vrt::collection::VrtElmProxy<MyCol, vt::Index1D>]" 
/vt/examples/callback/callback.cc(153): here

/vt/src/vt/pipe/pipe_manager.impl.h(135): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&MyObj::handler, Target=vt::objgroup::proxy::ProxyElm<MyObj>]"
          detected during instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&MyObj::handler, Target=vt::objgroup::proxy::ProxyElm<MyObj>]" 
/vt/examples/callback/callback.cc(147): here

/vt/src/vt/pipe/pipe_manager.impl.h(135): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&colHan, Target=vt::vrt::collection::VrtElmProxy<MyCol, vt::Index1D>]"
          detected during instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&colHan, Target=vt::vrt::collection::VrtElmProxy<MyCol, vt::Index1D>]" 
/vt/examples/callback/callback.cc(153%0D%0A%0D%0A%0D%0A ==> And there is more. Read log. <==

Build log

PR tests (intel icpc, ubuntu, mpich)

Build for 92ea7ec (2025-02-05 15:23:41 UTC)

remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhi%0D%0A%0D%0A%0D%0A ==> And there is more. Read log. <==

Build log

lifflander

Looks good overall. A few minor improvements requested

src/vt/metrics/perf_data.cc

src/vt/metrics/perf_data.h

cz4rs · 2025-01-21T15:39:13Z

@pierrepebay I was unable to reproduce the failures from both clang-9 and clang-10 builds (with identical settings as the workflows use). The tests pass just fine locally.

cz4rs · 2025-01-27T17:44:17Z

@pierrepebay See this for an example use of GTEST_SKIP:

vt/tests/unit/trace/test_runnable_context_trace.cc

Lines 61 to 63 in e4e445f

    
           TEST_F(TestRunnableContextTrace, runnable_context_trace_test_1) { 
        
             if (!theTrace()->checkDynamicRuntimeEnabled()) 
        
               GTEST_SKIP() << "trace tests require --vt_trace to be set";

cz4rs · 2025-02-03T18:22:50Z

src/vt/metrics/perf_data.cc

+    while (std::getline(ss, item, ','))
+    {


The formatting here is still incorrect:

Suggested change

while (std::getline(ss, item, ','))

{

while (std::getline(ss, item, ',')) {

src/vt/metrics/perf_data.cc

cz4rs

Looks good to me.

Co-authored-by: Cezary Skrzyński <[email protected]>

pierrepebay requested review from lifflander, cz4rs and nlslatt December 13, 2024 12:24

pierrepebay self-assigned this Dec 13, 2024

pierrepebay linked an issue Dec 13, 2024 that may be closed by this pull request

Add task measurements using Linux perf #2380

Closed

pierrepebay changed the title ~~Add task measurements using linux perf~~ #2380: Add task measurements using linux perf Dec 13, 2024

lifflander requested changes Dec 17, 2024

View reviewed changes

src/vt/metrics/perf_data.cc Outdated Show resolved Hide resolved

src/vt/metrics/perf_data.cc Outdated Show resolved Hide resolved

src/vt/metrics/perf_data.h Outdated Show resolved Hide resolved

pierrepebay force-pushed the 2380-add-task-measurements-using-linux-perf branch from 638b412 to 209632c Compare January 15, 2025 16:25

lifflander self-requested a review January 30, 2025 00:03

lifflander approved these changes Jan 30, 2025

View reviewed changes

pierrepebay added 11 commits February 3, 2025 12:41

#2380: metrics: Add build configuration option

d79a41f

#2380: metrics: Add perf data component

12a47e7

#2380: examples: Add perf data example

ef50b93

#2380: tests: Add perf data test

d167799

#2380: ci: Add perf data workflows

5678f61

#2380: examples: Fix perf data example

c68f792

#2380: metrics: Fix include guards

83972c1

#2380: tests: Fix metrics include guard

4afe040

#2380: metrics: Minor fixes

207f28f

#2380: tests: Disable assert tests for clang 9 and 10

819fd86

#2380: tests: Fix preprocessor clang if statements

8235013

pierrepebay force-pushed the 2380-add-task-measurements-using-linux-perf branch from 05d1f25 to 8235013 Compare February 3, 2025 17:41

cz4rs reviewed Feb 3, 2025

View reviewed changes

src/vt/metrics/perf_data.cc Outdated Show resolved Hide resolved

cz4rs approved these changes Feb 3, 2025

View reviewed changes

#2380: perf_data: Fix misplaced opening bracket

92ea7ec

Co-authored-by: Cezary Skrzyński <[email protected]>

lifflander merged commit 144f0ea into develop Feb 6, 2025
26 of 27 checks passed

pierrepebay mentioned this pull request Feb 10, 2025

#2302: Integrate PAPI in LB data export #2304

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#2380: Add task measurements using linux perf #2381

#2380: Add task measurements using linux perf #2381

pierrepebay commented Dec 13, 2024

github-actions bot commented Dec 13, 2024 •

edited

Loading

lifflander left a comment

cz4rs commented Jan 21, 2025

cz4rs commented Jan 27, 2025

cz4rs Feb 3, 2025

cz4rs left a comment

	while (std::getline(ss, item, ','))
	{
	while (std::getline(ss, item, ',')) {

#2380: Add task measurements using linux perf #2381

#2380: Add task measurements using linux perf #2381

Conversation

pierrepebay commented Dec 13, 2024

github-actions bot commented Dec 13, 2024 • edited Loading

Pipelines results

lifflander left a comment

Choose a reason for hiding this comment

cz4rs commented Jan 21, 2025

cz4rs commented Jan 27, 2025

cz4rs Feb 3, 2025

Choose a reason for hiding this comment

cz4rs left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 13, 2024 •

edited

Loading