Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor explode application to be callable and migrate Makefile tests to gtest format #5557

Closed
kledmundson opened this issue Jul 24, 2024 · 0 comments
Closed

Refactor explode application to be callable and migrate Makefile tests to gtest format #5557

kledmundson opened this issue Jul 24, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@kledmundson
Copy link
Contributor

Description

The explode application needs to be refactored to be callable. Makefile tests need to be replaced with gtests.

Example
@kledmundson kledmundson added the enhancement New feature or request label Jul 24, 2024
kledmundson added a commit to kledmundson/ISIS3 that referenced this issue Jul 24, 2024
@kledmundson
Added CHANGELOG entry for conversion of "explode" to a callable app. …
59c80ce 
…Addresses DOI-USGS#5557.
@kledmundson kledmundson mentioned this issue Jul 24, 2024
Closed
12 tasks
kledmundson added a commit to kledmundson/ISIS3 that referenced this issue Aug 15, 2024
@kledmundson
Updated explode application gtest to use DefaultCube fixture instead …
5517dcd 
…of cube in isis/tests/data. Addresses DOI-USGS#5557.
@kledmundson kledmundson mentioned this issue Aug 15, 2024
Merged
12 tasks
kledmundson added a commit to kledmundson/ISIS3 that referenced this issue Aug 15, 2024
@kledmundson
Cleaned up includes in default explode gtest. Added history entry to …
d36cd4e 
…explode.xml. Addresses DOI-USGS#5557.
kledmundson added a commit to kledmundson/ISIS3 that referenced this issue Aug 16, 2024
@kledmundson
Updating main.cpp and removed Makefile tests for explode conversion t…
490041e 
…o callable app. Addresses DOI-USGS#5557.
kledmundson added a commit to kledmundson/ISIS3 that referenced this issue Aug 17, 2024
@kledmundson
Added CHANGELOG entry for conversion of explode app to callable funct…
2a605d2 
…ion. Addresses DOI-USGS#5557.
acpaquette added a commit that referenced this issue Sep 11, 2024
@kledmundson @acpaquette
The explode application has been refactored to be callable and Makefi…
5e5b1d9 
…le test converted to a gtest. (#5590)

* Updated explode application gtest to use DefaultCube fixture instead of cube in isis/tests/data. Addresses #5557.

* Cleaned up includes in default explode gtest. Added history entry to explode.xml. Addresses #5557.

* Updating main.cpp and removed Makefile tests for explode conversion to callable app. Addresses #5557.

* Added CHANGELOG entry for conversion of explode app to callable function. Addresses #5557.

---------

Co-authored-by: Adam Paquette <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kledmundson @chkim-usgs