Noproj STILL doesn't clean up all files!

[kledmundson]

ISIS version(s) affected:
dev

Description

In testing the noproj app for upcoming modifications, Sarah Sutton (@artmathgirl) discovered that there was still a persistent temporary match file (extension lbl; e.g. matchXXXX.lbl) remaining after running noproj. This results from not closing the match cube after returning from the call to cam2cam (and sadly, I didn't catch it) e.g. ...

Code snippet from noproj.cpp (~line 375)...
// And run cam2cam to apply the transformation
QVector args = {"to=" + ui.GetCubeName("TO"), "INTERP=" + ui.GetString("INTERP")};
UserInterface cam2camUI(FileName("$ISISROOT/bin/xml/cam2cam.xml").expanded(), args);
Cube matchCube;
matchCube.open(matchCubeFile.expanded(), "rw");
cam2cam(icube, &matchCube, cam2camUI);
matchCube.close(); THE MISSING LINE

How to reproduce

Possible Solution

Close the matchCube.

Additional context

Related issue...

#4813