Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New lo_driver.py Incompatible with LROC NAC Images #571

Open
thea-mckenna opened this issue Oct 23, 2023 · 4 comments
Open

New lo_driver.py Incompatible with LROC NAC Images #571

thea-mckenna opened this issue Oct 23, 2023 · 4 comments

Comments

@thea-mckenna
Copy link

thea-mckenna commented Oct 23, 2023

Hi, myself and @steo85it got this error when trying to use a template csm script (see here at section 8.12.2) to convert LRO NAC cub files to jsons (which should not trigger an lo_driver.py call). Both of us have found that when reverting our cloned repos to the 57e0d2a commit this issue goes away and the conversion works. We think this might hint to an issue of the LO driver being called for LRO images. Although reverting to the other commit works, it is not optimal.

Screenshot 2023-10-19 at 1 43 14 PM
@thea-mckenna thea-mckenna changed the title Error with Latest Commit and LRO Driver New lo_driver.py Incompatible with LROC NAC Images Oct 23, 2023
@acpaquette
Copy link
Collaborator

@thea-mckenna This was introduced in the LO driver and we failed to update the recipe to pull the new dependency. For now to get things working with the most recent version of ALE you will need to run:

pip install affine6p

We will work to get this sorted and release a fixed version of ALE via conda-forge

@acpaquette
Copy link
Collaborator

In digging into this more, we can't ship ALE with affine6p since it is not available through conda-forge. For now we can disable the LO drivers and get a new version of ALE available.

@steo85it
Copy link

Hi @acpaquette , thanks for checking and for your reply! It is true that we did not try to simply pip install affine6p, we "blocked" on the fact that lo_drivers.py got called for an LROC NAC image, which was unexpected (that is another probe). We will check if that solves the issue and if yes, it's an easy fix (at least on our side).

@acpaquette
Copy link
Collaborator

@steo85it ALE is somewhat naive when looking for what driver to use, we basically try every driver until one succeeds. Generally, we get around this by enforcing drivers to only work with certain instrument ids but that can easily be broken if someone doesn't enforce that paradigm in a new driver.

That pip install should solve this issue and we can find a way to be smarter about driver selection

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants