Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove update_merge #130

Open
thodson-usgs opened this issue Jan 8, 2024 · 0 comments
Open

Remove update_merge #130

thodson-usgs opened this issue Jan 8, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@thodson-usgs
Copy link
Collaborator

thodson-usgs commented Jan 8, 2024

update_merge() is only called by _read_json() and should be removed or improved: For example, the current implementation will fail when the method code is 'x' (#129).

I tried replacing it with a simple merge, but this breaks multisite json queries,
which return a list of timeseries elements: one for each combination of site number and parameter. Thus we cannot merge, because parameter 2 of site 2 will already be populated by NA (from merging site 2 parameter 1, with site 1; and so on and so forth).

@thodson-usgs thodson-usgs self-assigned this Jan 8, 2024
@thodson-usgs thodson-usgs added the enhancement New feature or request label Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant