Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NLDI data retrieval functionalities. #135

Open
pkdash opened this issue Mar 8, 2024 · 1 comment
Open

Add NLDI data retrieval functionalities. #135

pkdash opened this issue Mar 8, 2024 · 1 comment

Comments

@pkdash
Copy link
Contributor

pkdash commented Mar 8, 2024

Here are some examples of function to retrieve NDLI data:

  • nldi.get_basin() - returns a geodataframe with a polygon geometry
  • nldi.get_flowlines() - returns a geodataframe with a polyline geometry
  • nldi.get_XYZ() - returns a geodataframe with a point geometry
  • nldi.search() - returns a JSON object
@pkdash pkdash changed the title Add NDLI data retrieval functionalities. Add NLDI data retrieval functionalities. Mar 8, 2024
@thodson-usgs
Copy link
Collaborator

Excellent, let's call XYZ nldi.get_location or get_point. I should've been more careful in my specification, but I meant "XYZ" figuratively as in "to list off several examples".

There are several point datasets within NLDI. I think a single get_point function is fine, but you might choose to split these further into "get_x", get_y", "get_z", etc. :)

Thanks for the update.

pkdash added a commit to pkdash/dataretrieval-python that referenced this issue Mar 8, 2024
pkdash added a commit to pkdash/dataretrieval-python that referenced this issue Apr 21, 2024
pkdash added a commit to pkdash/dataretrieval-python that referenced this issue Apr 22, 2024
pkdash added a commit to pkdash/dataretrieval-python that referenced this issue Apr 22, 2024
pkdash added a commit to pkdash/dataretrieval-python that referenced this issue Apr 22, 2024
thodson-usgs added a commit that referenced this issue Apr 28, 2024
* [#135] initial implementation of NLDI data access

* [#135] adding additional NLDI data access functionality

* [#135] convert boolean type query parameters to string type

* [#135] setting default distance to 5 kms for flowlines

* [#135] tests for NLDI data access

* Set NLDI optional dependency

* Fix python-package.yml

* Rollback geopandas for Python 3.8

* Throw warning to install geopandas

---------

Co-authored-by: thodson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants