Validate Database tool error (2.12.4): Duplicate error entries in ValidationErrors.html

[alwunder]

Validation script gives duplicate entries in some rules. Notable are 2.4, 2.6, 3.4, 3.6, and 3.8. I added some characters in front of a few examples in each section to make them stand out. See below:

2.6 Missing terms in Glossary. Only one reference to each missing term is cited
    table ContactsAndFaults, field Type, contact accurate
    table ContactsAndFaults, field Type, contact approximate
    table ContactsAndFaults, field Type, contact concealed
    ***table ContactsAndFaults, field ExistenceConfidence, certain
    >>>table ContactsAndFaults, field ExistenceConfidence, unspecified
    ***table ContactsAndFaults, field IdentityConfidence, certain
    ***table MapUnitPolys, field IdentityConfidence, certain
    table ContactsAndFaults, field Type, contact inferred
    table ContactsAndFaults, field Type, map neatline
    >>>table ContactsAndFaults, field IdentityConfidence, unspecified
2.8 Missing DataSources entries. Only one reference to each missing entry is cited
    @@@MapUnitPolys, field DataSourceID, TGSGQM_317SW_001
    @@@ContactsAndFaults, field DataSourceID, TGSGQM_317SW_001
    ContactsAndFaults, field DataSourceID, USGSMAPINDEX
    ContactsAndFaults, field DataSourceID, TGSGQM_317SW_005
3.4 Missing terms in Glossary. Only one reference to each missing term is cited
    +++table NaturalResourcePolys, field IdentityConfidence, certain
    +++table NaturalResourceLines, field ExistenceConfidence, certain
    table CartographicLines, field Type, map neatline
    table GMLabelLeaderLines, field Type, label leader
    +++table NaturalResourcePoints, field IdentityConfidence, certain
    table NaturalResourcePoints, field Type, open pit or quarry; abandoned
    table NaturalResourcePoints, field Type, drill hole (mineral test)
    table NaturalResourcePolys, field Type, open pit or quarry
    table NaturalResourcePoints, field Type, pit; abandoned
    table NaturalResourcePolys, field Type, pit; abandoned
    table NaturalResourceLines, field Type, open pit or quarry
    table OrientationPoints, field Type, bedding horizontal
    table OrientationPoints, field Type, bedding inclined
    +++table OrientationPoints, field IdentityConfidence, certain
    table NaturalResourceLines, field Type, pit; abandoned
    table NaturalResourcePoints, field Type, mine shaft; abandoned
    table NaturalResourcePoints, field Type, prospect or occurrence
    +++table NaturalResourceLines, field IdentityConfidence, certain
3.6 Missing DataSources entries. Only one reference to each missing entry is cited
    CartographicLines, field DataSourceID, USGSMAPINDEX
    $$$OrientationPoints, field OrientationSourceID, TGSGQM_317SW_001
    $$$NaturalResourcePolys, field DataSourceID, TGSGQM_317SW_001
    $$$GMLabelLeaderLines, field DataSourceID, TGSGQM_317SW_001
    $$$OrientationPoints, field LocationSourceID, TGSGQM_317SW_001
    $$$NaturalResourcePoints, field DataSourceID, TGSGQM_317SW_001
    NaturalResourcePoints, field LocationSourceID, TDEC_OGWDB
    NaturalResourcePoints, field DataSourceID, TDGBULL51
    $$$NaturalResourcePoints, field LocationSourceID, TGSGQM_317SW_001
    DataSourcePolys, field DataSourceID, TGSGQM_317SW_001
    $$$NaturalResourceLines, field DataSourceID, TGSGQM_317SW_001
    NaturalResourcePoints, field DataSourceID, TDEC_OGWDB
    NaturalResourcePoints, field LocationSourceID, TDGBULL51
3.8 MapUnits missing from DMU. Only one reference to each missing unit is cited
    Oc, field MapUnit, table OrientationPoints
    Olb, field MapUnit, table OrientationPoints
    Obc, field MapUnit, table OrientationPoints
    %%%Qal, field MapUnit, table OrientationPoints
    Oh, field MapUnit, table OrientationPoints
    %%%Qal, field MapUnit, table NaturalResourcePolys
    %%%Qal, field MapUnit, table NaturalResourcePoints
    Oh, field MapUnit, table NaturalResourcePoints
    Oc, field MapUnit, table NaturalResourcePoints
    Olb, field MapUnit, table NaturalResourcePoints
    Olcy, field MapUnit, table NaturalResourcePoints
    Obc, field MapUnit, table NaturalResourcePoints
    %%%Qal, field MapUnit, table NaturalResourceLines

[ethoms-usgs]

Is this mostly an issue of "Only one reference to each missing term is cited"? Because I think it could still be useful to have a report of a term being used in a table and field even if it's been reported as missing from another. For one thing, when the term or missing entry is added, the errors will go away.

Right now, the errors for each rule are appended to a list as they are found as table, field, term triples (or similar depending on the rule) and the list is converted to a set to eliminate duplicate triples. It's not that the term itself is evaluated.

But it makes sense to change the error headers to make it more clear.

[alwunder]

Ah, I see. It's the unique triple that is being reported. I guess in previous validations I either had not noticed it or just didn't have issues with missing terms across multiple locations in the database. My typical workflow has most attributes populated as the features are created, so I wouldn't have run into this issue very often (if at all).

The database that produced this report in particular was converted from a coverage, and I have been filling in values as I evaluate the quality of the linework. So, having the report give me the locations of the missing items probably does have its advantages.

I agree with your comment to change the error header. That makes what the tool is reporting clear to the user (and it's an easy fix).