From 78829da2b0151ee1b455c1debf8bbd95dcb30d2a Mon Sep 17 00:00:00 2001 From: David Blodgett Date: Sat, 20 Jul 2024 09:29:38 -0500 Subject: [PATCH 1/2] handle lowercase nhdplusid fixes #393 --- DESCRIPTION | 2 +- R/A_nhdplusTools.R | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/DESCRIPTION b/DESCRIPTION index 74f59863..d6ed12f1 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -1,7 +1,7 @@ Package: nhdplusTools Type: Package Title: NHDPlus Tools -Version: 1.2.1 +Version: 1.2.2 Authors@R: c(person(given = "David", family = "Blodgett", role = c("aut", "cre"), diff --git a/R/A_nhdplusTools.R b/R/A_nhdplusTools.R index 32802b15..5bc89a75 100644 --- a/R/A_nhdplusTools.R +++ b/R/A_nhdplusTools.R @@ -50,7 +50,7 @@ WBAREACOMI <- "WBAREACOMI" # List of input names that should be changed to replacement names nhdplus_attributes <- list( - COMID = COMID, NHDPlusID = COMID, + COMID = COMID, NHDPlusID = COMID, nhdplusid = COMID, Permanent_Identifier = Permanent_Identifier, RPUID = RPUID, VPUID = VPUID, From ede3166e431c4462d6ef800b1a7e134e3497b464 Mon Sep 17 00:00:00 2001 From: David Blodgett Date: Sat, 20 Jul 2024 11:38:12 -0500 Subject: [PATCH 2/2] skip web service tests on ci --- tests/testthat/test_01_get_nldi.R | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/testthat/test_01_get_nldi.R b/tests/testthat/test_01_get_nldi.R index 0789d97f..54786a1c 100644 --- a/tests/testthat/test_01_get_nldi.R +++ b/tests/testthat/test_01_get_nldi.R @@ -83,6 +83,7 @@ test_that("navigation works", { test_that("basin works", { skip_on_cran() + skip_on_ci() nldi_nwis <- list(featureSource = "nwissite", featureID = "USGS-05428500")