Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to parse "N95W18000 Appleton Ave, Menomonee Falls, WI" (PR welcome) #16

Open
ChandanNM opened this issue Apr 25, 2016 · 2 comments

Comments

@ChandanNM
Copy link

We are using this library in our application. Has worked fairly well for most of the US addresses, however fails for certain unusual but valid ones like - "N95W18000 Appleton Ave, Menomonee Falls, WI 53051" or other highway addresses. Can this library be enhanced to handle those ?

@markstos
Copy link
Collaborator

I've never seen a US street address with a street number with letters in like that. However, I searched for this address and it appears to be real. Strange. This case also fails with a competing parser:

https://www.npmjs.com/package/contact-parser

A pull request would accepted that fixes this case without breaking the other test cases.

@markstos markstos changed the title Fails to parse certain US address (Like the ones on Highways) Fails to parse "N95W18000 Appleton Ave, Menomonee Falls, WI" (PR welcome) Apr 26, 2016
@digitalcraft
Copy link
Collaborator

@ChandanNM, would you like to make a PR on this?

A core concept of the street address number is that it is in-fact a number.
This seems like some sort of highway marker where we would need to implement a special construct similar to apartment/unit to handle this.

I'm not familiar with the US Highway Address formats, I did find this spec from USPS, which I assume would contain a specification for the address format. http://pe.usps.com/text/pub28/welcome.htm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants