-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not Parsing 804/123-125 St Kilda Road Melbourne correctly #20
Comments
@PaulCaruana thanks for reporting this. I'll have a look into the case above. I think your second request is something that could be done also. I've come to realise that with the original implementation of addressit I've probably pushed the regexes as far as they can probably go and probably need to investigate something more advanced (such as using PEG.js, or similar). I'll see if I can carve out some time to investigate this over the next week or so. |
@PaulCaruana, I tried these with contact-parser](https://www.npmjs.com/package/contact-parser) package for a second opinion and it didn't parse them either. However, https://github.com/thrustlabs/contact-parser/blob/master/src/contact-parser.coffee |
@PaulCaruana just to keep you up to date on this, I've been looking at a pretty major refactor of the code under the hood (and at the same time adding some flow type validation for extra protection). The new implementation is still a little way off (but not too far). It will be far less regular expression based which is probably a good thing and I think will be more flexible. As far of your other question goes, yes, I think a comparison of two addresses that are actually the same address but just different in street type aliases will be considered equal. |
@DamonOehlman sounds exciting! PEG.js looks interesting. |
Hi, whenever a hyphen appears in street number and 'st' follows its not parsing correctly. In addition, is it possible to match addresses eg. "2 Holt St, Surry Hills" = "2 Holt Street, Surry Hills" Paul
The text was updated successfully, but these errors were encountered: