osfv_cli checks device in even if it was previously checked out manually #93
Comments
|
Thanks for the report, that is interesting to hear. Do you think that your case is covered in these tests: https://github.com/Dasharo/osfv-scripts/blob/main/osfv_cli/test/rte.robot ? |
|
|
|
Same thing with probe, it still checks asset in. Have you tried doing it manually with OptiPlex? without venv as I prefer to have Install logs
|
|
Confirm the issue on λ rte 192.168.10.107 pwr off
DUT model retrieved from snipeit: MSI PRO Z690-A DDR4
Using rte command is invasive action, checking first if the device is not used...
Asset 60 successfully checked out.
Powering off...
Since the asset 60 has been checkout automatically by this script, it is automatically checked in as well.
Asset 60 successfully checked in.After this I had the asset checked in. |
|
Can it be confirmed via running automated test? Let me know if you need any support here. |
|
@macpijan have you tested on current main, fresh install? We should probably add CI. Isn't equal to expected After modifying test a little (trimming multiple whitespace): diff --git a/osfv_cli/test/rte.robot b/osfv_cli/test/rte.robot
index f6524a5bf9ae..c591d8793b77 100644
--- a/osfv_cli/test/rte.robot
+++ b/osfv_cli/test/rte.robot
@@ -44,11 +44,13 @@ Test Flash Probe - Asset Checked Out Manually
... not checked in after the script finishes execution.
Check Out ${RTE_IP_APU2}
${probe_result}= Run Flash Probe ${RTE_IP_APU2}
+ ${stdout}= Set Variable ${probe_result.stdout}
+ ${trimmed_probe_result}= Evaluate re.sub(r"\\s\\s+", " ", $stdout)
Should Match
- ... ${probe_result.stdout}
+ ... ${trimmed_probe_result}
... *Since the asset ${ASSET_ID_APU2} has been checkout manually by you prior running this script, it will NOT be checked in automatically.*
Should Match
- ... ${probe_result.stdout}
+ ... ${trimmed_probe_result}
... *Please return the device when work is finished.*
${list_result}= Run Process osfv_cli snipeit list_my
Should Match ${list_result.stdout} *Asset ID: ${ASSET_ID_APU2}*Test fails when making sure that asset is still checked out Python packages installed
|
|
And also in tests we have: Are those always safe to Check In? (osfv_cli check_in works even if platform is checked out by someone else) |
No, nothing is, that is one of the reasons why it's not in the CI, unless we figure it out. Moving it to: #100 |
I thought I have, but there's been no new commit since then. So apparently I have not. Thanks for bringing this up. I can reproduce this problem now. |
m-iwanicki
added a commit
to Dasharo/open-source-firmware-validation
that referenced
this issue
Feb 11, 2025
Resolves requests exception error and Dasharo/osfv-scripts#93 Signed-off-by: Michał Iwanicki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue
When using
osfv_cli pwr *device is checked in even if it was checked out manuallyIt probably shouldn't do that based on
osfv_cli version
The text was updated successfully, but these errors were encountered: