Upgrade schema is failing to upgrade a new database.

[rajrku]

Fails to retrieve the schema name from the connection string when there is an extra space in the connection string - From Azure Portal the Connection strings have an extra space among the parts.

Potential fix is in the foreach loop where the token is trimmed any extra spaces.

File: src\dbup-mysql\MySqlExtensions.cs

public static class MySqlExtensions
{
    /// <summary>
    /// Creates an upgrader for MySql databases.
    /// </summary>
    /// <param name="supported">Fluent helper type.</param>
    /// <param name="connectionString">MySql database connection string.</param>
    /// <returns>
    /// A builder for a database upgrader designed for MySql databases.
    /// </returns>
    public static UpgradeEngineBuilder MySqlDatabase(this SupportedDatabases supported, string connectionString)
    {
        foreach (var pair in connectionString.Split(';').Select(s => s.Split('=')).Where(pair => pair.Length == 2).Where(pair => pair[0].Trim().ToLower() == "database"))
        {
            return MySqlDatabase(new MySqlConnectionManager(connectionString), pair[1]);
        }

        return MySqlDatabase(new MySqlConnectionManager(connectionString));
    }

[AdrianJSClark]

Just for clarity, the code above is here: https://github.com/DbUp/DbUp/blob/d7170c5118c07a0adb2a47d9bef65dfb9008a46c/src/dbup-mysql/MySqlExtensions.cs#L27

That code makes me very uneasy. We should be using the appropriate connection string builder for MySQL rather than parsing the value ourselves.

I believe the class is MySqlConnectionStringBuilder (according to https://dev.mysql.com/doc/connector-net/en/connector-net-ref-mysqlclient.html after some quick searching).

[mjauernig]

See also #5

[droyad]

Duplicate of #5