Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to Turn Off Gamma Ramp #133

Open
ChthonVII opened this issue Jul 22, 2024 · 0 comments
Open

Option to Turn Off Gamma Ramp #133

ChthonVII opened this issue Jul 22, 2024 · 0 comments

Comments

@ChthonVII
Copy link

I could be wrong here, since the bsnes code is more than a bit of a spaghetti tangle, but it looks to me like you inherited a bug where both the gamma ramp kludge and hardcoded 1.5 gamma were applied in retroarch. I see that you fixed the hardcoded 1.5 gamma to a selectable gamma defaulting to 1.0. But it also looks like you accidentally removed the line that was disabling the gamma ramp kludge, at least for the standalone build. (I assume, perhaps wrongly, that the 1.5 gamma in bsnes was meant as a replacement for the gamma ramp that wasn't implemented evenly for standalone and retroarch.)

Especially for retroarch, it would be nice to have an option to get raw R'G'B' so that CRT gamma emulation can be handled properly in shaders.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant