Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support disable directives #184

Open
DonIsaac opened this issue Dec 28, 2024 · 0 comments
Open

Support disable directives #184

DonIsaac opened this issue Dec 28, 2024 · 0 comments
Labels
A-linter Area - linter and lint rules C-enhancement Category - New feature or request good first issue Good for newcomers

Comments

@DonIsaac
Copy link
Owner

DonIsaac commented Dec 28, 2024

Partially implemented by #169 (directive parsing) and #172 (global directives). Line-specific directives still need to be implemented. All the pieces exist

AC

  • Ignore checks should be done only when a violation is reported.
    • hypothesis: directives aren't common, and lint violations are even less common
  • Directives should only be parsed when a comment is found above a diagnostic. No parsing should happen before its needed
  • Parse results should be cached. Do not parse the same comment twice.
@DonIsaac DonIsaac mentioned this issue Dec 28, 2024
20 tasks
@DonIsaac DonIsaac added C-enhancement Category - New feature or request good first issue Good for newcomers A-linter Area - linter and lint rules labels Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - linter and lint rules C-enhancement Category - New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant