Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDISP001 should warn for local tuples #165

Open
JohanLarsson opened this issue Mar 7, 2019 · 0 comments
Open

IDISP001 should warn for local tuples #165

JohanLarsson opened this issue Mar 7, 2019 · 0 comments

Comments

@JohanLarsson
Copy link
Collaborator

        [TestCase("Tuple.Create(↓File.OpenRead(file), 1)")]
        [TestCase("Tuple.Create(↓File.OpenRead(file), ↓File.OpenRead(file))")]
        [TestCase("new Tuple<FileStream, int>(↓File.OpenRead(file1), 1)")]
        [TestCase("new Tuple<FileStream, FileStream>(File.OpenRead(file1), ↓File.OpenRead(file1))")]
        public void LocalTuple(string expression)
        {
            var testCode = @"
namespace RoslynSandbox
{
    using System;
    using System.IO;

    public sealed class C : IDisposable
    {
        public C(string file)
        {
            var tuple = Tuple.Create(↓File.OpenRead(file), 1);
        }
    }
}".AssertReplace("Tuple.Create(↓File.OpenRead(file), 1)", expression);

            AnalyzerAssert.Diagnostics(Analyzer, ExpectedDiagnostic, testCode);
        }

        [TestCase("(↓File.OpenRead(file), 1)")]
        [TestCase("(↓File.OpenRead(file), ↓File.OpenRead(file))")]
        [TestCase("(1, ↓File.OpenRead(file))")]
        public void LocalValueTuple(string expression)
        {
            var testCode = @"
namespace RoslynSandbox
{
    using System;
    using System.IO;

    public sealed class C : IDisposable
    {
        public C(string file)
        {
            var tuple = (↓File.OpenRead(file), 1);
        }
    }
}".AssertReplace("(↓File.OpenRead(file), 1)", expression);

            AnalyzerAssert.Diagnostics(Analyzer, ExpectedDiagnostic, testCode);
        }

        [TestCase("Pair.Create(↓File.OpenRead(file1), ↓File.OpenRead(file2))")]
        [TestCase("new Pair<FileStream>(↓File.OpenRead(file1), ↓File.OpenRead(file2))")]
        public void LocalPair(string expression)
        {
            var staticPairCode = @"
namespace RoslynSandbox
{
    public static class Pair
    {
        public static Pair<T> Create<T>(T item1, T item2) => new Pair<T>(item1, item2);
    }
}";

            var genericPairCode = @"
namespace RoslynSandbox
{
    public class Pair<T>
    {
        public Pair(T item1, T item2)
        {
            this.Item1 = item1;
            this.Item2 = item2;
        }

        public T Item1 { get; }

        public T Item2 { get; }
    }
}";

            var testCode = @"
namespace RoslynSandbox
{
    using System;
    using System.IO;

    public sealed class C : IDisposable
    {
        public C(string file1, string file2)
        {
            var pair = Pair.Create(↓File.OpenRead(file1), ↓File.OpenRead(file2));
        }
    }
}".AssertReplace("Pair.Create(↓File.OpenRead(file1), ↓File.OpenRead(file2))", expression);

            AnalyzerAssert.Diagnostics(Analyzer, ExpectedDiagnostic, genericPairCode, staticPairCode, testCode);
        }
JohanLarsson added a commit that referenced this issue Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant