New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

install.ps1 & uninstall.ps1 broken #87

Open

JohanLarsson opened this issue May 25, 2018 · 0 comments

Collaborator

JohanLarsson commented May 25, 2018 •

edited

Loading

Repro:

Create a project that uses old csproj
Install Gu.Analyzers
Install IDisposableAnalyzers does not add <Analyzer Include="..\packages\IDisposableAnalyzers .2.0.2.2\analyzers\dotnet\cs\Gu.Roslyn.AnalyzerExtensions.dll" />
Uninstall IDisposableAnalyzers removes <Analyzer Include="..\packages\Gu.Analyzers.1.2.12.1-dev\analyzers\dotnet\cs\Gu.Roslyn.AnalyzerExtensions.dll" />

$project.Object.AnalyzerReferences.Remove($dllPath.FullName)

https://docs.microsoft.com/en-us/dotnet/api/vslangproj140.analyzerreferences?view=visualstudiosdk-2017

Looks like ^ only checks FileName and not FullFileName when adding and removing.

Also by only having one analyzer reference for the shared dll different versions will not be handled.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment