Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn if GetNestedType is not checked for null or offer refactoring to throw on error #186

Open
jnm2 opened this issue Nov 3, 2018 · 0 comments
Open

Warn if GetNestedType is not checked for null or offer refactoring to throw on error #186

jnm2 opened this issue Nov 3, 2018 · 0 comments

Comments

@jnm2
Copy link
Collaborator

jnm2 commented Nov 3, 2018

Should GetNestedType be treated as a special case of GetType so that the existing #14 check is applied?

That would be cool because I'd totally prefer a refactoring from type.GetNestedType to type.Assembly.GetType("RepeatedTypeName+NestedTypeName, throwOnError: true) over avoiding NRE manually.
@jnm2 jnm2 changed the title Warn if GetNestedType is not checked for null or ovver refactoring to throw on error Warn if GetNestedType is not checked for null or offer refactoring to throw on error Nov 3, 2018
ErikWahlstrom pushed a commit to ErikWahlstrom/ReflectionAnalyzers that referenced this issue Apr 5, 2019
@JohanLarsson
GU0023 don't warn when used in lambda. Fix DotNetAnalyzers#186.
bcf68e2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jnm2