Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

誰がマージするの？ #5

Open
1 task done
Gaddict opened this issue Jan 27, 2016 · 5 comments
Open
1 task done

誰がマージするの？ #5

Gaddict opened this issue Jan 27, 2016 · 5 comments

Comments

@Gaddict
Copy link
Member

Gaddict commented Jan 27, 2016

そのタイミングを放置する場合、プルリクがたまっていくから煩雑になる気がするな
プルリクのタイトルさえわかりやすければ、特に問題はないと思う
タイトルから、言語とかやってることがわかると見やすい気がする

  • ルールを決めてREADMEに書く
@pollseed
Copy link
Member

Wikiに更新

https://github.com/DreamHackers/CodeReview/wiki/%E3%83%AB%E3%83%BC%E3%83%AB#%E3%83%97%E3%83%AB%E3%83%AA%E3%82%AF%E3%81%AE%E3%83%9E%E3%83%BC%E3%82%B8

@pollseed
Copy link
Member

👍

@Gaddict
Copy link
Member Author

Gaddict commented Jan 27, 2016

レビュー担当者って書いてあるけど
これはプルリク作った人以外でいいんだよね

@pollseed
Copy link
Member

Exactly!

@Gaddict
Copy link
Member Author

Gaddict commented Jan 27, 2016

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Gaddict @pollseed