Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inherited properties are not inherited (FontObj) #367

Open
cursork opened this issue Feb 11, 2025 · 1 comment
Open

Inherited properties are not inherited (FontObj) #367

cursork opened this issue Feb 11, 2025 · 1 comment

Comments

@cursork
Copy link
Contributor

cursork commented Feb 11, 2025

This is a more general issue, but this issue will be closed when FontObj on containers such as SubForm is correctly handled by contained objects. The simplest reproduction case is with Label. Minimal example from ⎕WC:

  'F1'⎕WC'Form'('Coord' 'Pixel')
  'F1.FNT'⎕WC'Font'('PName' 'Courier')('Italic' 1)('Underline' 1)('Size' 50)
  'F1.L1'⎕WC'Label' 'Test one'('Posn' 50 50)
  'F1.SF'⎕WC'SubForm'('Posn' 100 50)('FontObj' 'F1.FNT')
  'F1.SF.L1'⎕WC'Label' 'Test two'('Posn' 10 10)
Image

From a quick search, these need to be checked to see if they suffer from the issue:

  • Button ✅
  • Combo ✅
  • Edit ✅
  • Grid ✅
  • Label ✅
  • List ✅
  • ListView ❗
  • Menu - didn't seem to change in Windows
  • MenuBar - as above
  • Ribbon - to address as a whole
    • RibbonButton
    • RibbonButtonGroup
    • RibbonDropDownButton
    • RibbonDropDownGallery
    • RibbonGroup
    • RibbonItem
  • Text ✅
  • Treeview ❗
cursork added a commit that referenced this issue Feb 11, 2025
This commit fixes FontObj for Label, Button and Edit

Note that this also provides a *generalised* approach to inheritance.
The existing code tried to do this via eg assuming that a text-decoration
CSS style would be inherited. It is not. See
https://developer.mozilla.org/en-US/docs/Web/CSS/text-decoration
cursork added a commit that referenced this issue Feb 11, 2025
This commit fixes FontObj for Label, Button and Edit

Note that this also provides a *generalised* approach to inheritance.
The existing code tried to do this via eg assuming that a text-decoration
CSS style would be inherited. It is not. See
https://developer.mozilla.org/en-US/docs/Web/CSS/text-decoration
@cursork
Copy link
Contributor Author

cursork commented Feb 11, 2025

Commit c132c85 is the first stage of tackling FontObj everywhere. I get a similar result in EWC and ⎕WC for my simple example above (and for Button and Edit).

I will look at other usages of FontObj before closing. Edited description contains ❗ marks for all those trivially tested in ⎕WC to respect eg an outer subform's FontObj - so they likely need an update in JS too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant