-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inherited properties are not inherited (FontObj) #367
Comments
cursork
added a commit
that referenced
this issue
Feb 11, 2025
This commit fixes FontObj for Label, Button and Edit Note that this also provides a *generalised* approach to inheritance. The existing code tried to do this via eg assuming that a text-decoration CSS style would be inherited. It is not. See https://developer.mozilla.org/en-US/docs/Web/CSS/text-decoration
cursork
added a commit
that referenced
this issue
Feb 11, 2025
This commit fixes FontObj for Label, Button and Edit Note that this also provides a *generalised* approach to inheritance. The existing code tried to do this via eg assuming that a text-decoration CSS style would be inherited. It is not. See https://developer.mozilla.org/en-US/docs/Web/CSS/text-decoration
Commit c132c85 is the first stage of tackling FontObj everywhere. I get a similar result in EWC and ⎕WC for my simple example above (and for Button and Edit). I will look at other usages of FontObj before closing. Edited description contains ❗ marks for all those trivially tested in ⎕WC to respect eg an outer subform's FontObj - so they likely need an update in JS too. |
cursork
added a commit
that referenced
this issue
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is a more general issue, but this issue will be closed when FontObj on containers such as SubForm is correctly handled by contained objects. The simplest reproduction case is with Label. Minimal example from ⎕WC:
From a quick search, these need to be checked to see if they suffer from the issue:
The text was updated successfully, but these errors were encountered: