-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add preprocessor to extract surface values from 3D atmospheric variables #2641
base: main
Are you sure you want to change the base?
Conversation
@bouweandela if you could point me to where in the documentation I should add relevant information ? Thanks 🙂 |
In this file, please: https://github.com/ESMValGroup/ESMValCore/blob/main/doc/recipe/preprocessor.rst You can find this, and much more useful information on contributing, under the links in the checklist above and in our contribution guidelines: https://docs.esmvaltool.org/projects/ESMValCore/en/latest/contributing.html |
Here is an interesting example of doing something similar for ocean data: https://cosima-recipes.readthedocs.io/en/latest/Recipes/Extract_Variables_at_Ocean_Bottom.html I guess the ocean equivalent of |
…plementation and tests
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2641 +/- ##
==========================================
+ Coverage 94.92% 94.94% +0.02%
==========================================
Files 252 252
Lines 14593 14652 +59
==========================================
+ Hits 13853 13912 +59
Misses 740 740 ☔ View full report in Codecov by Sentry. |
@bouweandela I think I managed to update the code accordingly with the call to |
Description
This pull request introduces a new preprocessor function to extract the surface values from 3D atmospheric variables and corresponding surface pressure
ps
. The preprocessor function is largely based on the implementation done for the derivation of surface CO2co2s
at https://github.com/ESMValGroup/ESMValCore/blob/main/esmvalcore/preprocessor/_derive/co2s.py. It thus avoids having to create either at standalone_derive
preprocessor or a new entry in the relevant CMOR tables. The attributes of the 3D atmospheric variables are transferred to the newly created cube and the variable name is changed tof'{var_name}s'
.Closes #2611
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: