Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temporarily missing urls #1

Closed
flugsio opened this issue Feb 5, 2025 · 1 comment
Closed

temporarily missing urls #1

flugsio opened this issue Feb 5, 2025 · 1 comment
Assignees

Comments

@flugsio
Copy link

flugsio commented Feb 5, 2025

hey, thanks for this awesome project!

last run 377897d nuked the urls, I've looked through the code and ran it locally. It seems to work fine now, so it just needs to run again.

The urls have changed from the previous version, so maybe the guide was updated at the exact same time. Not sure it's worth adding a guard against it, just wanted to let you know

for example, pleasant valley changed from
https://steamuserimages-a.akamaihd.net/ugc/37814745481699824/C9745785ADF9844B76B23DB10D06B151EC80114B/
to
https://steamuserimages-a.akamaihd.net/ugc/37819645136728807/C9745785ADF9844B76B23DB10D06B151EC80114B/

@Elektronixx Elektronixx self-assigned this Feb 5, 2025
@Elektronixx
Copy link
Owner

Interesting.

Difficult to say what happened, but as you said, ive ran the action again and everything is fine now.
I added a quick manual exception throw when no href is found, this should prevent future empty overrides.

Thanks for letting me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants