Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for upcoming Boost 1.87.0 #812

Closed
cho-m opened this issue Nov 20, 2024 · 2 comments
Closed

Add support for upcoming Boost 1.87.0 #812

cho-m opened this issue Nov 20, 2024 · 2 comments

Comments

@cho-m
Copy link

cho-m commented Nov 20, 2024

Issue Description

While testing the beta of upcoming Boost 1.87.0 in Homebrew (Homebrew/homebrew-core#198115), UHD failed to build due to using deprecated Boost Asio APIs that were removed, e.g. boostorg/asio@ec0908c

async_writer(boost::asio::io_service *io,

This issue is mainly intended as advance notice. Boost 1.87.0 release is planned for December 11.

Setup Details

Homebrew build environment. Shouldn't be OS/arch specific. CI hit this on macOS 13-14 (x86_64), macOS 13-15 (arm64) and Ubuntu 22.04 (x86_64).

Expected Behavior

Successful build.

Actual Behaviour

Compilation fails with errors like:

host/lib/deps/rpclib/include/rpc/detail/async_writer.h:22:31: error: no type named 'io_service' in namespace 'boost::asio'
   22 |     async_writer(boost::asio::io_service *io,
      |                  ~~~~~~~~~~~~~^

Steps to reproduce the problem

Easiest way to reproduce may using CXXFLAGS=-DBOOST_ASIO_NO_DEPRECATED on Boost 1.66.0 - 1.86.0

An identical reproduction would be building recent 1.87.0.beta1.

Additional Information

Updating Boost minimum to 1.66.0 should allow replacing most/all deprecated APIs. If older Boost support is needed, then will require various #if BOOST_VERSION checks to support.

@mbr0wn
Copy link
Contributor

mbr0wn commented Nov 21, 2024

Thanks for the report! Yes we want to support the upcoming Boost.

@joergho joergho closed this as completed Dec 11, 2024
@mbr0wn
Copy link
Contributor

mbr0wn commented Dec 11, 2024

@cho-m Thanks again for reporting. We just finished an internal review of the required changes, and they will go live soon. Next time we push UHD public, the master branch will have this fix, as will the next stable release of UHD.

We did in fact increase the minimum Boost version to 1.66, as you hinted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants