Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PoC for accordion-style session types on FAQ #989

Draft
wants to merge 2 commits into
base: ep2025
Choose a base branch
from
Draft

PoC for accordion-style session types on FAQ #989

wants to merge 2 commits into from

Conversation

hypha
Copy link
Contributor

@hypha hypha commented Feb 3, 2025

Fixes #985

This is a PoC for the accordion-style layout for session types. I’m exploring this approach to explain what the different session types are without cluttering the FAQ page too much.

Currently, this includes only a few sections (Talks, Tutorials, Workshops, and Summits) to gather feedback before expanding further.

  • @egeakman, could you review the styling? If this isn’t the right approach, any suggestions for improvement or new ideas are welcome!
  • I’ve tried to make this work with screen readers with very limited knowledge. We can ask the accessibility team to verify and improve after Ege confirms this is generally the right direction.
  • More content will be added after styling is sorted.

@hypha hypha marked this pull request as draft February 3, 2025 18:20
@hypha hypha requested a review from egeakman February 3, 2025 18:21
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025 •
edited
Loading

Preview available

Key Value
url https://ep2025-session-types.ep-preview.click
last update 2025-02-03T18:21:37.860Z

@egeakman
Copy link
Member

egeakman commented Feb 3, 2025

Hi Raquel, thanks for the PR! I think it looks great.

Little extra note: It might be nice if we extract the code into components in the future so it's less work for the team. Let's actually open a meta issue for the components needed, so we have a list to work on.

In the meantime, I think using this style/code is perfectly good.

@hypha
Copy link
Contributor Author

hypha commented Feb 4, 2025 •
edited
Loading

@egeakman thanks for the feedback! <3

Little extra note: It might be nice if we extract the code into components in the future so it's less work for the team. Let's actually open a meta issue for the components needed, so we have a list to work on.

100%! That’s largely why I held back from typing away. Repeating all the styling is a pain to type and for content reviewers!

How about I open a separate PR for the accordion component? (I’m hoping to first get some accessibility team's feedback). That way, we can tick off one component from the future list. Once the component is ready, I can merge it into this content PR. Since this content is an improvement/good-to-have, we can afford to take the time to do it well. WDYT?

@hypha hypha mentioned this pull request Feb 5, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egeakman egeakman Awaiting requested review from egeakman

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide more explanations on Talks, Tutorials and Sprints on the FAQ page
2 participants
@hypha @egeakman