Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Best practices TODO #7

Open
10 of 15 tasks
anandbaburajan opened this issue Oct 9, 2020 · 4 comments
Open
10 of 15 tasks

Best practices TODO #7

anandbaburajan opened this issue Oct 9, 2020 · 4 comments

Comments

@anandbaburajan
Copy link
Contributor

anandbaburajan commented Oct 9, 2020

Code

  • Proper readable and maintable code with consistent spacing and indentation
  • Functions follow the "Do One Thing" rule (single-responsibility)
  • Followed DRY (Don’t Repeat Yourself)
  • Added comments wherever required
  • Proper naming conventions
  • Avoided deep nesting

Readme

  • Badges (similar to the Gitter badge. You can maybe use: https://shields.io/)
  • Description (why this project exists)
  • Features (working of the project)
  • Setup (Quick start instructions with how to download and use your project)
  • Contributing (How can others contribute?)
  • License ("This project is licensed under the ")

Tests and CI/CD

  • Wrote tests
  • Deployed the project (if possible)
  • Added CI/CD tools to your project (maybe CircleCI or TravisCI) (if possible)
@anandbaburajan
Copy link
Contributor Author

@anasvakyathodi, great work, thanks for contributing and helping others get started with open source! You're just left with a few items in your TODO! For the readme, I'd suggest to refer the readme here. Also, the Todo section in your readme can be made a bit more prominent.

@anasvakyathodi
Copy link
Collaborator

@anasvakyathodi, great work, thanks for contributing and helping others get started with open source! You're just left with a few items in your TODO! For the readme, I'd suggest to refer the readme here. Also, the Todo section in your readme can be made a bit more prominent.

Sure @anandbaburajan ... Thanks for your help :)

@anandbaburajan
Copy link
Contributor Author

anandbaburajan commented Dec 18, 2020

Also it would be better if console.log() statements were replaced with logging and you can put a .env.example too. You can use https://swagger.io/ for the API docs too.

@anasvakyathodi
Copy link
Collaborator

anasvakyathodi commented Dec 21, 2020

Okay Thanks @anandbaburajan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants