Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] truncated is commented out #1131

Open
1 task done
qelloman opened this issue Aug 3, 2024 · 1 comment
Open
1 task done

[Bug Report] truncated is commented out #1131

qelloman opened this issue Aug 3, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@qelloman
Copy link

qelloman commented Aug 3, 2024

Describe the bug

NOTE: This is my first issue report, so the format might be wrong.
There is a discrepancy in Mountain Car environment between documentation and code implementation.

According to the gymnasium documentation, Mountain Car env is supposed to be truncated when the elapsed step exceeds 200.
However, the code comments out the truncatation part and guides users to use TimeLimit wrapper.

The documentation is needed to be updated.

Code example

# truncation=False as the time limit is handled by the `TimeLimit` wrapper added during `make`
        return np.array(self.state, dtype=np.float32), reward, terminated, False, {}

System info

gymnasium is installed via pip.
gymnasium==0.29.1
MacOS 14.5
Python==3.8.19

Additional context

No response

Checklist

  • I have checked that there is no similar issue in the repo
@qelloman qelloman added the bug Something isn't working label Aug 3, 2024
@pseudo-rnd-thoughts
Copy link
Member

Thanks for the issue, could you clarify what the problem with the documentation is
Do you want a link to TimeLimit or the part of the make function that allows?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants