You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Why these Nginx module don't care this point?
Because, the rfc 9110 says that Cache-Control: no-transform does not apply to message transformations that do not change the content, such as the addition or removal of transfer codings.
Thus I consider that the compression features indicates a such message transformations(addition Transfer-Encoding: gzip etc...), it should be available these features.
A proxy MUST NOT transform the content ([Section 6.4](https://www.rfc-editor.org/rfc/rfc9110.html#content)) of a response message that contains a no-transform cache directive ([Section 5.2.2.6](https://www.rfc-editor.org/rfc/rfc9111#section-5.2.2.6) of [[CACHING](https://www.rfc-editor.org/rfc/rfc9110.html#CACHING)]).
Note that this does not apply to message transformations that do not change the content, such as the addition or removal of transfer codings ([Section 7](https://www.rfc-editor.org/rfc/rfc9112#section-7) of [[HTTP/1.1](https://www.rfc-editor.org/rfc/rfc9110.html#HTTP11)]).
However, I think we can do better in Rust / Tide. For that kind of use-case we could export a special type and detect that on the request extensions, like a struct NoCompress;.
tide-compress/src/middleware.rs
Lines 125 to 134 in 845698b
I consider that we don't have to care any Cache-Control: no-transform to compress any contents.
For example, Nginx gzip filter doesn't care this headers, also the ngx_brotli module does.
https://github.com/nginx/nginx/blob/master/src/http/modules/ngx_http_gzip_filter_module.c#L220
https://github.com/google/ngx_brotli/blob/master/filter/ngx_http_brotli_filter_module.c
Why these Nginx module don't care this point?
Because, the rfc 9110 says that
Cache-Control: no-transform
does not apply to message transformations that do not change the content, such as the addition or removal of transfer codings.Thus I consider that the compression features indicates a such message transformations(addition Transfer-Encoding: gzip etc...), it should be available these features.
https://www.rfc-editor.org/rfc/rfc9110.html
If you agree this approach, I would like to work on this issue.
Just removing the procedure to confirm the Cache-Control: no-transform.
The text was updated successfully, but these errors were encountered: