-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add id check to auto checker #47
Comments
Done by #50 |
I didnt close this because the part where we include flow's default plugin ids as well is not done. This helps if anyone would copy those plugins as a starter but forgets to change the id, or this is overkill? |
Base on #71, there also need to sync upstream plugin id to manifest . Daily update Id is fine. But how to handle this condition. Upstream plugin id was changed to new one and this new id was already in manifest. |
No, if u look at the pr, the ID submitted was different to the repo at the very start. So we just need to validate on new plugin submission to check against the id in the plugin repo. ID is the unique identifier so should never change after first init. |
I forget once a plugin id is changed flow would treat that plugin to a new plugin. |
hey, i am interested in this issue, can you assign this issue to me. |
@prachhii31 thanks for putting your hand up for this. This issue might be no longer accurate as recently we started publishing default plugins into the manifest as well, so maybe no further change is required. However if you could just test and verify this, it would be great also, so we can close this issue off. |
id needs to be unique as is used for matching existing plugin to download/update. Since this info is manually added into plugin.json, let's enforce it with auto checker here.
Need to also take into consideration of default flow launcher plugins' ids as well.
The text was updated successfully, but these errors were encountered: