Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flux Extension #57

Closed
wants to merge 6 commits into from
Closed

Flux Extension #57

wants to merge 6 commits into from

Conversation

vpuri3
Copy link

@vpuri3 vpuri3 commented Jan 30, 2024

@darsnack
Copy link
Member

#55 makes this moot, no? I guess I haven't had time to deal with the Documenter issue, so some help there would be appreciated. Otherwise, let's release #55 even without switching the docs system.

@vpuri3
Copy link
Author

vpuri3 commented Jan 30, 2024

@darsnack, I wasn't sure if #55 was active when I started looking at this. In any case, it would be great to get this merged in the meantime so we can get rid of the Flux dependency. And when #55 comes out, it can revamp Scheduler and move it from ParameterSchedulersFluxExt.jl -> ParameterSchedulersOptimisersExt.jl

@vpuri3
Copy link
Author

vpuri3 commented Jan 31, 2024

@darsnack ping

@darsnack
Copy link
Member

darsnack commented Feb 1, 2024

Sorry I should have been more clear. The intent with #55 is to avoid creating an extension entirely by depending only on Optimisers.jl which is light weight. I'd also like to avoid releasing a Flux extension then switching it to an Optimisers extension.

I'll merge and release #55 today instead.

@vpuri3
Copy link
Author

vpuri3 commented Feb 1, 2024

That would be great, thank you @darsnack

@darsnack darsnack mentioned this pull request Feb 2, 2024
2 tasks
@darsnack darsnack closed this in #55 Feb 3, 2024
@vpuri3 vpuri3 deleted the flux branch February 3, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants