-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: catppuccinMocha: Color contrast for owner comments is too low #6597
Comments
Hi everyone, I’ve worked on the color contrast issue for the uploader’s comments in the Catppuccin Mocha theme (#6597). I’ve made adjustments to the CSS to ensure the contrast ratio is improved for better readability and accessibility. Specifically, I modified the colors related to the uploader's username highlight, making it more distinguishable against the background. I’ve tested the changes locally on macOS 11 and can confirm that the contrast is now more pronounced, meeting the accessibility standards. You can find the relevant pull request here: #6603. Looking forward to your feedback, and let me know if further adjustments are needed. Thank you! |
Love it, thank you! :) |
While I am grateful to @nanikh91, since the PR is stale, I'd like to work on it myself and try to fix the contrast (assuming no new commits or other PRs wish to address this issue). |
go for it! |
Title: Description: I’ve worked on resolving the color contrast issue for the uploader’s comments in the Catppuccin Mocha theme (#6597). I made adjustments to the CSS to improve the contrast ratio, ensuring better readability and accessibility for users on Windows. Specifically, I modified the colors related to the uploader's username highlight to make it more distinguishable against the background. Here are the key updates: The color contrast ratio has been improved to meet accessibility standards (4.5:1 and above). #7025 Thank you! |
@artkapl do you have trouble implementing the requested changes in your PR? |
Guidelines
Describe the bug
Expected Behavior
A clear label for an uploader's comment, no matter the theme used. This is important for accessibility.
Issue Labels
accessibility issue
FreeTube Version
v0.22.1
Operating System Version
Windows 10 22H2
Installation Method
.exe
Primary API used
Local API
Last Known Working FreeTube Version (If Any)
No response
Additional Information
See https://webaim.org/resources/contrastchecker/?fcolor=1E1E2E&bcolor=181825, a contrast ratio of 1.07:1 is much too low. A rule of thumb is at least 4.5:1 for proper legilibility.
The relevant CSS properties are
card-bg-color
andsecondary-card-bg-color
for.catppuccinMocha
Screenshots:
Catppuccin Mocha:

Dark theme:

Nightly Build
The text was updated successfully, but these errors were encountered: