Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look at current use of JavaScript managed cookies #1056

Closed
robotdan opened this issue Jan 7, 2021 · 1 comment
Closed

Look at current use of JavaScript managed cookies #1056

robotdan opened this issue Jan 7, 2021 · 1 comment

Comments

@robotdan
Copy link
Member

robotdan commented Jan 7, 2021

Possible issues with cookies that may break in future browser versions.

Description

We have some cookies that are not secure, and are very simply values that we drop in JavaScript.

I saw this in Firefox, perhaps we need to write out the cookie differently.

Some cookies are misusing the recommended “SameSite“ attribute 2
Cookie “fusionauth.timezone” will be soon rejected because it has the “SameSite” attribute set to “None” or an invalid value, without the “secure” attribute. To know more about the “SameSite“ attribute, read https://developer.mozilla.org/docs/Web/HTTP/Headers/Set-Cookie/SameSite

We may need to set the Secure flag based upon the schema we detect in the browser if we aren't already. We should look at fusionauth.timezone or any other cookie we may drop in JavaScript.

@robotdan
Copy link
Member Author

robotdan commented Sep 28, 2021

Closing as handed under #1414

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant