Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show missing URLs on Identity Provider CORS Warning #2985

Open
ATLJLawrie opened this issue Jan 28, 2025 · 2 comments
Open

Only show missing URLs on Identity Provider CORS Warning #2985

ATLJLawrie opened this issue Jan 28, 2025 · 2 comments
Labels
enhancement New feature or request ux

Comments

@ATLJLawrie
Copy link

Only show missing URLs on Identity Providor CORS Warning

Problem

In order to expose metadata to external parties we need to Enable Identity Provider Integrations without know their specific IdP URLs. Thus we typically just put in some dummy / placeholder value. This properly triggers the CORS filter warning however to those who aren't aware the warning shows all active IdP domains.

Solution

Have the CORS warning only show the specific domains / URLs that are missing.

Additional context

Add any other context or screenshots about the feature request here.

Community guidelines

All issues filed in this repository must abide by the FusionAuth community guidelines.

How to vote

Please give us a thumbs up or thumbs down as a reaction to help us prioritize this feature. Feel free to comment if you have a particular need or comment on how this feature should work.

@mooreds
Copy link
Collaborator

mooreds commented Mar 10, 2025

@ATLJLawrie just so I understand, the issue is:

  • you have a SAML identity provider that is correctly configured and has a domain like example.com added to FusionAuth CORS
  • you create a new SAML Identity Provider and put in dummy values (abc.com) that is not added to CORS
  • the CORS error shows up and shows both example.com and abc.com to all users

Is that correct?

And your problem is that this exposes information to people who should not see it, or that it is confusing? Or is there another concern I am missing?

@ATLJLawrie
Copy link
Author

Thanks @mooreds

Your understanding of the issue is 100% correct.

Effectively the feature request is to hide the correctly configured domains as it can be confusing to someone more of a AzureAD sets up SAML background which is the user type whom we have manage our SSO relations in our app. Effectively our goal would be since we use dummy IDP urls during the intial token exchange we could rapidlly dismiss the CORS error if it only contained those dummy URLs

@mooreds mooreds added enhancement New feature or request ux labels Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ux
Projects
None yet
Development

No branches or pull requests

2 participants