-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add User: incorrect years in "Birthdate" date picker #561
Comments
Bug is likely in the date picker widget. https://github.com/inversoft/prime.js/blob/master/src/main/js/Widgets/DateTimePicker.js If anyone wants to take a crack at it and fix it, a PR would be great. |
@robotdan |
If you look at the code ( https://github.com/inversoft/prime.js/blob/7ae67b0e586e98f454750c942d1c53bc2983d59a/src/main/js/Widgets/DateTimePicker.js#L256 ) you'll see the intended behavior is to show 10 years in either direction of the current value. I would start with just fixing it so the behavior matches the intention. |
@robotdan I think you misunderstood. I corrected the code already, now the year range would be 100 years before the current year to the current year. What I was asking is should I go for 100 years or maybe 90 or 80 years. |
@amans330 I agree for BirthDate, years should be listed decreasing |
@amans330 not sure I follow. Once you have the bug fixed, you can submit a PR and I can look at it, I'm sure your questions ill be clearer once I look at the code. Thanks! |
PR --> inversoft/prime.js#25 |
We'll be moving to an HTML 5 date picker. |
here is a decent replacement using HTML 5 in a self service form. This just an example, but it will set the min and max age for birthdays based upon the current year.
|
Add User: incorrect years in "Birthdate" date picker
Description
The years go into the future.
Steps to reproduce
Steps to reproduce the behavior:
Expected behavior
Some years ago (perhaps 100 years ago?) up to this year.
Screenshots
Platform
(Please complete the following information)
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: