Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Training Report - Selecting an Agency w/o Bureau No Results Returned #728

Open
JennaySDavis opened this issue Jan 8, 2025 · 2 comments
Open

BUG: Training Report - Selecting an Agency w/o Bureau No Results Returned #728

JennaySDavis opened this issue Jan 8, 2025 · 2 comments
Assignees
@johnbeallgsa
Labels
Bug Something isn't working Sprint 47

Comments

@JennaySDavis
Copy link
Contributor

JennaySDavis commented Jan 8, 2025 •
edited
Loading

When an A/OPC or Admin user selects an Agency that has Bureaus associated with it the system does not return results.

To replicate:

  • Select an Agency with bureaus associated, U.S. General Services Administration
  • Do not select a bureau
  • Generate Report; no results returned in the report
@JennaySDavis JennaySDavis added the Bug Something isn't working label Jan 8, 2025
@JennaySDavis JennaySDavis mentioned this issue Jan 8, 2025
Open
@JennaySDavis
Copy link
Contributor Author

728 Acceptance Criteria

Pass/Fail Description
A/OPCs
Pass Select an Agency that has Bureaus, but doesn't select a Bureau; Report Generated with Correct Results
Pass Select an Agency/Bureau, Report Generated with Correct Results
Pass Select Agency w/o Bureaus, Report Generated with Correct Results
Admin
Pass Select an Agency that has Bureaus, but doesn't select a Bureau; Report Generated with Correct Results
Pass Select an Agency/Bureau, Report Generated with Correct Results
Pass Select Agency w/o Bureaus, Report Generated with Correct Results

Comments/Additional Notes
N/A

ADA Compliance (Automated scan via Chrome Lighthouse)

Criteria Score
Performance 97
Accessibility 100
Best Practices 100

Passed 01/21/2025 - JSD

@johnbeallgsa
Copy link

Works as advertised. Moving to Done. Thank you!

felder101 added a commit that referenced this issue Jan 23, 2025
@felder101
Production Release
84cfbdf 
Sprint 47 issues includes:
Dependabot Alert: Atro CSRF Middleware Bypass (security.checkOrigin) #720
Dependabot Alert: Astro's server source code is exposed to the public if source maps are enabled #725
Update to the latest version of USWDS 3.11.0 #722
BUG: Training Report - Selecting an Agency w/o Bureau No Results Returned #728
Update SMTP to reflect GSA IT naming convention standard #736
@felder101 felder101 mentioned this issue Jan 23, 2025
Merged
felder101 added a commit that referenced this issue Jan 24, 2025
@felder101
Production Release (#743)
6f089f3 
Sprint 47 issues includes:
Dependabot Alert: Atro CSRF Middleware Bypass (security.checkOrigin) #720
Dependabot Alert: Astro's server source code is exposed to the public if source maps are enabled #725
Update to the latest version of USWDS 3.11.0 #722
BUG: Training Report - Selecting an Agency w/o Bureau No Results Returned #728
Update SMTP to reflect GSA IT naming convention standard #736
felder101 added a commit that referenced this issue Mar 14, 2025
@john-labbate @weiwang-gsa
@mark-meyer @felder101
Feature/678 add guid to gspc emails (#761)
1d8fce6 
* update UI portion to match api changes

* code clean up

* address test error

* implement structured logs and use gunicorn to manage worker processes

* simplify documentation

* add gunicorn to requirements

* use correct flags for gunicorn--sigh

* try without gunicorn

* spacificy stdout for log stream

* Production Release (#609)

Includes sprint 34 and 34 issues

Link Checker #369
Adding Drone Content to all Trainings #599
Adding FASCSA Order Check to all Trainings #598
Accessibility Bug: Buttons without Accessible Names on all Trainings Print Training Functionality #591
Admin Panel - Display Completed Quizzes/Certificates for Users #317
Research solutions for implementing audit fields #451
Update GSPC Image #601
Log Tracking Editing of User Records #443

* #606 set session timeout to 15min.

* Admin: Deleting Reporting Access in the UI is not deleting the record in the Database #605
Configure the system to end sessions at 15 minutes to meet the requirement CA-9 #606
User Research Feedback - UI Changes to GSPC #604

* Update USWDS to latest version 3.8.2 | Training #615
Dependabot Alert: Server-Side Request Forgery in axios #620

* Coommit includes the following: (#634)

- Titles of FASCA and Drone in all Trainings #616
- User Profile > Save Changes Without Returning the User to the Search Results Screen #621
- Bug: Admin User unable to download another user's certificate #623
- Dependabot Alert: Server-Side Request Forgery in axios #620

* commit includes:: The system must collect each answer on each quiz taken #549 (#652)

BUG: Update Titles on FASCSA and Drone #631
Update Treasury lesson links #647
Dependabot Alert: Regular Expression Denial of Service (ReDoS) in micromatch #628

* Production Release (#662)

Issue #635 Create Search Functionality
Issue #656 Sprint 40 Content Changes
Issue #637 Update the descriptions on each training card

* Production Release (Sprint 41) (#677)

Dependabot Alert: Vite's server.fs.deny is bypassed when using ?import&raw #651
Dependabot Alert: Vite DOM Clobbering gadget found in vite bundled scripts that leads to XSS #650
Dependabot Alert: Vite DOM Clobbering gadget found in vite bundled scripts that leads to XSS #650
Biobased in Training #663

* Sprint 42 (#691)

* Production Release (#708)

Sprint 44 Issues:
December 2024 Separation Report - Remove User #702
Static Code Vulnerability: js/incomplete-URL-substring-sanitization #698

* Production Release (#721)

Sprint 45
Add Admin Permission to User- Sean Sayler #712
Update to latest version of USWDS 3.10.0 #699
Dependabot Alert: Regular Expression Denial of Service (ReDoS) in cross-spawn #703

* Gsa/production release (#731)

* Production Release

Sprint 46 issues included:

BUG: Admin/User Profile Saved Changes are Not Displayed on Results screen #709
BUG: Insert a space between the date field of Completion date range end and Quiz type(s) on the SmartPay Training Report #705
Customizable Training Report for A/OPC #633

* Fixed merge issue

* Added finally block to reset loading and show spinner boolean value

* Update Fedrooms broken link

* Production Release (#743)

Sprint 47 issues includes:
Dependabot Alert: Atro CSRF Middleware Bypass (security.checkOrigin) #720
Dependabot Alert: Astro's server source code is exposed to the public if source maps are enabled #725
Update to the latest version of USWDS 3.11.0 #722
BUG: Training Report - Selecting an Agency w/o Bureau No Results Returned #728
Update SMTP to reflect GSA IT naming convention standard #736

* Production Release (#756)

* Production Release

Sprint 48 issues includes:

Federal Website Standards - Meta Page Descriptions #715
Remove All Content/References to Executive Order (E.O.) 14081 #746
Add Asterisk to the 4-digit Prefixes where referenced throughout website and add additional content #745
Federal Website Standards - HTML Page Titles #714

* Add mailto link to email per code review comments

* WIP testing performance changes.

* WIP template out email background task

* extend background task timeout.

* batch out bulk inset.

* add missing smtp quit.

* Fix bulk save error.

* method tweeks and more logging.

* Update Procfile

* more logging!

* Update gspc_invite.py

* fixed bug

* update logging.

* Pass server settings into background task.

* Job optimization, documentation.

* Testing and cleanup.

* lint fixes.

* lint fixes.

* Update gspc completion test.

* fix more unit test.

* fix test.

* Atempt 2 at fixing test that only fail on server.

* testiong reverts.

* Update placeholder email

* re-add whitespace

* Update uaa.yml

* revert auth.py

* revert the correct file.

* revert another file.

---------

Co-authored-by: weiwang-gsa <[email protected]>
Co-authored-by: Wei Wang <[email protected]>
Co-authored-by: Mark Meyer <[email protected]>
Co-authored-by: Dan Felder <[email protected]>
Co-authored-by: Dan Felder <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnbeallgsa johnbeallgsa

Labels
Bug Something isn't working Sprint 47
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johnbeallgsa @JennaySDavis