Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we be storing the Docker layer cache? #22

Open
ferdnyc opened this issue Jan 29, 2025 · 0 comments
Open

Should we be storing the Docker layer cache? #22

ferdnyc opened this issue Jan 29, 2025 · 0 comments

Comments

@ferdnyc
Copy link
Member

ferdnyc commented Jan 29, 2025

It strikes me that, since Docker images are built in layers, changing the set of packages installed with npm (which is like the 4th major layer of 5, in the image build) shouldn't require rebuilding the first three layers, if they're already in the Docker cache.

But that'd require us to use actions/cache (or a Docker-specific version of same) to store and retrieve the cache of intermediate layers, so that each build doesn't have to start from scratch.

Might be worth doing, at least for situations like my idiocy today. (Where I updated the npm install... step three times in quick succession, necessitating SIX (three PR CI, three post-merge deploy) redundant builds of the first three image layers.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant