fix

Author: LeXXik

src/physics/jolt/back/operators/creator.mjs

@@ -676,6 +676,7 @@ class Creator {
         const id = cb.read(BUFFER_READ_INT32);
         const bodyInterface = backend.bodyInterface;
 
+        let ok = true;
         let body, bodyID;
         if (id < 0) {
             body = bodyInterface.CreateBody(bodyCreationSettings);
@@ -686,16 +687,26 @@ class Creator {
             // skip the check for production build
             if ($_DEBUG) {
                 const eb = backend.physicsSystem.GetBodyLockInterfaceNoLock().TryGetBody(bodyID);
-                if (eb?.IsInBroadPhase()) {
-                    Debug.warn('Trying to add a new body with a custom ID that already belongs ' +
-                        'to another existing body in the physics world. Skipping body creation.');
+                if (Jolt.getPointer(eb)) {
+                    Debug.warn(`Trying to add a new body with a custom ID (${id}) that already ` +
+                        'belongs to another existing body in the physics world. Skipping body ' +
+                        'creation.');
+                    ok = false;
                 }
             }
 
             body = bodyInterface.CreateBodyWithID(bodyID, bodyCreationSettings);
+
+            if ($_DEBUG && !Jolt.getPointer(body)) {
+                Debug.warn(`Failed to create a body with custom id: ${id}`);
+                return false;
+            }
+        }
+
+        if (ok) {
+            bodyInterface.AddBody(bodyID, Jolt.EActivation_Activate);
         }
 
-        bodyInterface.AddBody(bodyID, Jolt.EActivation_Activate);
         body.isometryUpdate = cb.read(BUFFER_READ_UINT8);
 
         if ($_DEBUG) {
@@ -707,13 +718,15 @@ class Creator {
         Jolt.destroy(shapeSettings);
         Jolt.destroy(bodyCreationSettings);
 
-        if (backend.config.useMotionStates &&
-            useMotionState &&
-            (jmt === Jolt.EMotionType_Dynamic || jmt === Jolt.EMotionType_Kinematic)) {
-            body.motionState = new MotionState(body);
-        }
+        if (ok) {
+            if (backend.config.useMotionStates &&
+                useMotionState &&
+                (jmt === Jolt.EMotionType_Dynamic || jmt === Jolt.EMotionType_Kinematic)) {
+                body.motionState = new MotionState(body);
+            }
 
-        backend.tracker.add(body, index);
+            backend.tracker.add(body, index);
+        }
 
         return true;
     }