Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fontconfig #299

Open
bjarthur opened this issue Sep 14, 2018 · 10 comments
Open

fontconfig #299

bjarthur opened this issue Sep 14, 2018 · 10 comments

Comments

@bjarthur
Copy link
Member

the problem with using Compose, Cairo, Fontconfig on master is due at least in part to const no longer working in local scopes. src/pango.jl is included within link_fontconfig() and the lib strings defined therein are hence not constant when ccall needs them to be.

@Mattriks
Copy link
Member

Mattriks commented Sep 14, 2018

and other issues on master ...

Another issue is that there are 4 images missing in the latest docs, which appear in stable. These images all use LCHab color - has the Colors package been added to the environment in which the docs are built?

@tlnagy
Copy link
Member

tlnagy commented Sep 14, 2018

These images all use LCHab color - has the Colors package been added to the environment in which the docs are built?

No. I think that slipped past me.

tlnagy added a commit that referenced this issue Sep 15, 2018
fix doc requirements loading, working on #299
@tlnagy
Copy link
Member

tlnagy commented Sep 16, 2018

src/pango.jl is included within link_fontconfig() and the lib strings defined therein are hence not constant when ccall needs them to be.

What's the solution to this given that Cairo is loaded conditionally?

@bjarthur
Copy link
Member Author

i think the clean approach is to move all ccalls using libpango and libpangocairo in Compose.jl to Cairo.jl with thin wrappers which Compose.jl would then call. if @lobingera concurs, i will start working in this direction.

@tlnagy
Copy link
Member

tlnagy commented Sep 20, 2018

I think that's the best approach. Maybe worth posting the idea over there in case @lobingera checks that?

@lobingera
Copy link

@tlnagy
Copy link
Member

tlnagy commented Sep 26, 2018

Any progress on this? I think we should tag a release for Compose today or tomorrow.

@bjarthur
Copy link
Member Author

i've been slowly working on it. i'm okay with tagging. but i'll have some time this weekend if you want to wait. see JuliaInterop/Clang.jl#206

@CiaranOMara
Copy link
Contributor

In Compose.jl, fontconfig is included by Fontconfig.jl, which is pulled in by MikeInnes/Requires.jl. However, in Cairo.jl, fontconfig is included as part of its build.jl.

The build.jl in Fontconfig.jl does not provide pango. But, the build.jl in Cairo.jl does provide pango.

I'm having difficulty understanding how pango provided to Cairo.jl would be available to Compose.jl in the scope of the link_fontconfig() callback. Would pango not also need to be provided to Fontconfig.jl through its build.jl?

@bjarthur
Copy link
Member Author

i'm working on completely overhauling the Compose interface to pango/fontconfig/cairo... it's all broken now which is why i was reluctant to tag the latest version a couple weeks ago. am stuck on BinaryBuilder; see my four issues there. hopefully all will be resolved soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants