Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use UIView.TintAdjustmentMode #34

Open
ivan-magda opened this issue Aug 23, 2018 · 6 comments
Open

Use UIView.TintAdjustmentMode #34

ivan-magda opened this issue Aug 23, 2018 · 6 comments
Labels
question Further information is requested

Comments

@ivan-magda
Copy link
Member

Hey, @rnystrom

I think it would be nice to update tintAdjustmentMode like Apple UI controls do.
If you wish I can create a PR, just two lines of code:

  • on appear
UIApplication.shared.keyWindow?.tintAdjustmentMode = .dimmed
  • on disappear
UIApplication.shared.keyWindow?.tintAdjustmentMode = .normal

ezgif com-resize

@rnystrom
Copy link
Member

Scratching my head, what’s he difference? What value does this add? I’m not familiar with the API.

Sent with GitHawk

@rnystrom rnystrom added the question Further information is requested label Sep 13, 2018
@av0c0der
Copy link
Contributor

av0c0der commented Jan 5, 2019

@rnystrom seems like you didn't note how the color of UIBarButtonItems have changed? .dimmed tint mode makes them black & white, this API is used in UIAlertController.

@rnystrom
Copy link
Member

rnystrom commented Jan 5, 2019

@jauzee what do you mean about the color change?

@av0c0der
Copy link
Contributor

av0c0der commented Jan 5, 2019

@rnystrom I meant tint color of the buttons on the gif.

@rnystrom
Copy link
Member

rnystrom commented Jan 5, 2019

Oh now I see it! TIL that’s a thing. I’m down with offering this as an optional config.

Sent with GitHawk

@av0c0der
Copy link
Contributor

av0c0der commented Jan 5, 2019

@rnystrom one thing to note here — if we apply tintAdjustmentMode on the key window it will apply it on the presented view controller's subviews too.

I've also read about this API just a few weeks ago. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Development

No branches or pull requests

3 participants