Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Swift 4.2 and iOS 12 #36

Open
LambdaDigamma opened this issue Sep 23, 2018 · 5 comments
Open

Update to Swift 4.2 and iOS 12 #36

LambdaDigamma opened this issue Sep 23, 2018 · 5 comments

Comments

@LambdaDigamma
Copy link

Carthage Build for iOS 12 project fails with exit code 65. This usually indicates that project itself failed to compile.

./ContextMenu/ContextMenuPresentationController.swift:56:30: error: value of type 'CGRect' has no member 'dominantCorner'
@yonlau
Copy link

yonlau commented Sep 25, 2018

I encounter same issue, please help to update for that, thanks!

@manuelsalinas-legion
Copy link

Hello @rnystrom Will you give support for iOS 12 and swift 4.2?

@yonlau
Copy link

yonlau commented Oct 3, 2018

Use the latest version and build the code, drag the ContextMenu into to project manually solve my problem!

@rnystrom
Copy link
Member

Merged #37 for 4.2 support. I don't use Carthage, so not sure what's going on there.

FYI this project is open source, don't have to wait on me for a fix 😉

@sbarow
Copy link
Contributor

sbarow commented Oct 28, 2018

#41 should fix Swift 4.2 support for Carthage checkouts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@rnystrom @sbarow @yonlau @LambdaDigamma @manuelsalinas-legion