Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make NSLinkAttribute to tappable and highlighting. #51

Open
ryohey opened this issue Aug 13, 2018 · 4 comments
Open

Make NSLinkAttribute to tappable and highlighting. #51

ryohey opened this issue Aug 13, 2018 · 4 comments
Labels

Comments

@ryohey
Copy link
Contributor

ryohey commented Aug 13, 2018

Hi, Thank you for this amazing library.

I have a question about links and attributes.
StyledTextKit provides three attributes .tapable, .tapHighlight, .highlight.
Are there use-cases for using these attributes separately?
These just increase complexity in my opinion.

As alternative for UITextView, Is it not enough to have only NSLinkAttribute?

@rnystrom
Copy link
Member

@ryohey NSLinkAttribute has some weird default styling that you can't override, pretty funky behavior.

.tapable is only in an example

We could def use some documentation the two highlight options.

@kylelol now that I'm reading the code, did #47 change the behavior of .highlight? If you were previously using that to do interactive highlighting, do you now have to know to update your code to use .tapHighlight from now on?

@ryohey
Copy link
Contributor Author

ryohey commented Sep 23, 2018

@rnystrom oh i see. I didn't know that's behavior. now I think it is a good to use .highlight.
I hope that .highlight is the only attribute to do interactive highlighting.

@kylelol
Copy link
Collaborator

kylelol commented Sep 24, 2018

@rnystrom ah you are right, I think if you were previously using .highlight you would have to update your code to use .tapHighlight. I can switch it back to the way it was to prevent regressions, and maybe pick a more descriptive name like .interactiveHighlight

@rnystrom
Copy link
Member

@kylelol that’d be great!

Sent with GitHawk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants