Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate render and style params from building #61

Open
rnystrom opened this issue Dec 1, 2018 · 0 comments
Open

Separate render and style params from building #61

rnystrom opened this issue Dec 1, 2018 · 0 comments
Assignees

Comments

@rnystrom
Copy link
Member

rnystrom commented Dec 1, 2018

Love this blog post! Removing all color/font from building would be amazing. Instead:

  • Use "style builder" pattern that registers styles
    • Need to still be able to "push" and "pop" styles
    • Should all props be in one style (.font, .foregroundColor, etc), or should there be a style per prop? Latter seems harder to maintain
  • Remove UIContentSizeCategory from all params until render

Necessary to make progress towards GitHawkApp/GitHawk#198 so you can have themes/styles and re-render (missing all caches) w/out having to rebuild everything (which you'd have to do today).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant