Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No next/previous slide controls on Android for Media Session API #796

Open
d-tayl opened this issue Mar 14, 2023 · 9 comments
Open

No next/previous slide controls on Android for Media Session API #796

d-tayl opened this issue Mar 14, 2023 · 9 comments

Comments

@d-tayl
Copy link

d-tayl commented Mar 14, 2023

https://googlechrome.github.io/samples/media-session/slides.html

On Chrome 111.0.5563.58 on Android I can see the PIP window when trying this sample but there doesn't seem to be any controls for triggering the nextslide/previousslide actions. This works fine in Windows Chrome on version 111.

I'm having the same issue when implementing the functionality myself, where it'll work fine on Windows but display no controls on Android.

Operating system as listed in Chrome:
Android 13;SM-G781B Build/TP1A.220624.014

Had a colleague try it on his phone (Samsung Galaxy S22 Ultra this time) and had the same thing.

Is this awaiting an OS update or something else external for the controls to show in Android? The try/catch method for checking support of these features isn't failing at this point on either phone.

@beaufortfrancois
Copy link
Member

Chrome on Android supports the slides media session actions but doesn't show icons in the Picture-in-Picture window yet. It is working only on desktop for now.

I've started https://chromium-review.googlesource.com/c/chromium/src/+/4350267 to address this issue.
Hopefully, you'll be able to use them soon.

Spoiler:
image

@d-tayl
Copy link
Author

d-tayl commented Mar 17, 2023

Chrome on Android supports the slides media session actions but doesn't show icons in the Picture-in-Picture window yet. It is working only on desktop for now.

I've started https://chromium-review.googlesource.com/c/chromium/src/+/4350267 to address this issue. Hopefully, you'll be able to use them soon.

Spoiler: image

Thank you for the update. They look beautiful and I can't wait!

@beaufortfrancois
Copy link
Member

Out of curiosity, are you going to use it in your web app?

@d-tayl
Copy link
Author

d-tayl commented Mar 17, 2023

Sure. We have a remote slide presentation tool that works across a few platforms/presentation tools with a web interface. This'll mean users can bring up their notes app/a live stream of their event/whatever they like without losing sight of the current slide or control of it. Is working perfectly on Windows Chrome so far.

IMG-20230313-WA0009(1)

@beaufortfrancois
Copy link
Member

Oh nice! Can I try it?

@d-tayl
Copy link
Author

d-tayl commented Mar 17, 2023

Not yet, I'm afraid. It's currently in our testing environment and not publicly available. Releases are out of my hands so I'm sure when it'll be live either, sorry.

aarongable pushed a commit to chromium/chromium that referenced this issue Mar 20, 2023
This CL adds the "previous slide" and "next slide" action to the
Picture-in-Picture on Android when the website sets slides action
handers through the Media Session API.

Issue: GoogleChrome/samples#796
Test: https://googlechrome.github.io/samples/media-session/slides.html
Bug: 1363548
Change-Id: Ic8dd41f33748ebaf5d0586f679fa29dc229e6a1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4350267
Reviewed-by: Frank Liberato <[email protected]>
Commit-Queue: Fr <[email protected]>
Reviewed-by: Boris Sazonov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1119232}
@beaufortfrancois
Copy link
Member

beaufortfrancois commented Mar 21, 2023

@d-tayl https://chromium-review.googlesource.com/c/chromium/src/+/4350267 has landed in latest update of Chrome Canary for Android if you want to try it. Let me know if that works fine for your use case.

@d-tayl
Copy link
Author

d-tayl commented Mar 21, 2023

@d-tayl https://chromium-review.googlesource.com/c/chromium/src/+/4350267 has landed in latest update of Chrome Canary for Android if you want to try it. Let me know if that works fine for your use case.

Just tried it and it's working perfectly. Thank you very much for looking into this and getting back to me!

Screenshot_20230321_102505_Samsung Notes

One thing that's outside of this issue but I figure I should flag: I didn't previously have Canary and the PiP window would close when the browser was in the background. It worked after I closed the app and toggled PiP permissions on and off (I'm not sure which part helped). My colleague had a similar experience with the BETA Chrome app when we first looked at this so I'm guessing it's to do with the default permissions maybe? (PiP seems to be allowed by default)

Thanks again,
Daniel

@beaufortfrancois
Copy link
Member

One thing that's outside of this issue but I figure I should flag: I didn't previously have Canary and the PiP window would close when the browser was in the background. It worked after I closed the app and toggled PiP permissions on and off (I'm not sure which part helped). My colleague had a similar experience with the BETA Chrome app when we first looked at this so I'm guessing it's to do with the default permissions maybe? (PiP seems to be allowed by default)

I'd suggest you file a Chromium bug at https://crbug.com/new so that the Chrome team can have a look at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants