Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when CWV antipatterns are detected #113

Open
rviscomi opened this issue Apr 7, 2023 · 2 comments
Open

Warn when CWV antipatterns are detected #113

rviscomi opened this issue Apr 7, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@rviscomi
Copy link
Member

rviscomi commented Apr 7, 2023

This post covers a few of the most effective CWV optimizations. Add the ability for the extension to console.warn when the page isn't following best practices.

A good proof of concept to start might be lazy-loaded LCP images.

@rviscomi rviscomi added the enhancement New feature or request label Apr 7, 2023
@tunetheweb
Copy link
Member

I'm concerned about all the nuances we might need here.

For native lazy-loading images that's probably fairly obvious and OK. For JS lazy-loading that takes more logic. And for delayed loading due to injecting the LCP element and/or having it in CSS that's more knowledge.

Then for fetchpriority we don't want to create more noise by pushing that on people if it won't even make a difference (e.g. it arrives, even before the images is needed).

There's often a lot of nuance in Lighthouse audits to handle these things and don't think we should be aiming to replicate that here.

@rviscomi
Copy link
Member Author

Yeah, let's start with native lazy loading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants