Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't unblock interception if last interception is removed #2147

Closed
Lightning00Blade opened this issue Apr 22, 2024 · 0 comments · Fixed by #2135
Closed

Don't unblock interception if last interception is removed #2147

Lightning00Blade opened this issue Apr 22, 2024 · 0 comments · Fixed by #2135

Comments

@Lightning00Blade
Copy link
Collaborator

Lightning00Blade commented Apr 22, 2024

WebDriver BiDi requires that a request continues to be blocked even if you remove all it's interceptions are removed.
In CDP if the Fetch.disable is called successfully, all the request that were blocked will be continued with out any overrides.
This means we have to either workaround this issue Prototype: #2135

The problem is that this introduces certain problems when we leave the request hanging (block then never continue).
The main issue seems to be with AuthRequired events as that blocks any further navigation until resolved.
Trying to navigate to a different page seems to work as the (blocked) request is aborted by the render.

Also another problem is we can't disable the Network domain while there is a blocked request.

Chromium inspector-protocol navigation test: https://chromium-review.googlesource.com/c/chromium/src/+/5463590 (seems to work with content-shell)
Chromium browser_tests: https://chromium-review.googlesource.com/c/chromium/src/+/5472256
Chromium inspector-protocol disable Network test: https://chromium-review.googlesource.com/c/chromium/src/+/5465648

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant