Review comments changes

Author: saranyaloganathan23

src/batches/createBatch.tsx

@@ -396,7 +396,7 @@ function CreateBatch({
           if (batchInfoResponse.runtimeConfig.hasOwnProperty('properties')) {
             const updatedPropertyDetail = Object.entries(
               batchInfoResponse.runtimeConfig.properties
-            ).map(([k, v]) => `${k.substring(6)}:${v}`);
+            ).map(([k, v]) => `${k.substring(6)}:${v}`); // spark:spark.app.name , spark:spark.driver.cores - every property is appended with 'spark:' therefore getting the porperty key value after 'spark:' 
             setPropertyDetail(prevPropertyDetail => [
               ...prevPropertyDetail,
               ...updatedPropertyDetail

src/index.ts

@@ -72,7 +72,7 @@ const extension: JupyterFrontEndPlugin<void> = {
     window.addEventListener('beforeunload', () => {
       localStorage.removeItem('notebookValue');
     });
-    let localStorageValue = '';
+    let lastClusterName = '';
     const panel = new Panel();
     panel.id = 'dpms-tab';
     panel.title.icon = iconDpms;
@@ -89,15 +89,15 @@ const extension: JupyterFrontEndPlugin<void> = {
 
 
     panel.addWidget(new dpmsWidget(app as JupyterLab, themeManager));
-    localStorageValue = localStorage.getItem('notebookValue') || '';
-    if (localStorageValue) {
-      loadDpmsWidget(localStorageValue);
+    lastClusterName = localStorage.getItem('notebookValue') || '';
+    if (lastClusterName) {
+      loadDpmsWidget(lastClusterName);
     }
     app.shell.add(panel, 'left', { rank: 1000 });
 
     const onTitleChanged = async (title: Title<Widget>) => {
       const widget = title.owner as NotebookPanel;
-      localStorageValue = localStorage.getItem('notebookValue') || '';
+      lastClusterName = localStorage.getItem('notebookValue') || '';
       if (widget && widget instanceof NotebookPanel) {
         const kernel = widget.sessionContext.session?.kernel;
         if (kernel) {
@@ -109,28 +109,28 @@ const extension: JupyterFrontEndPlugin<void> = {
             const parts =
               kernelSpec?.resources.endpointParentResource.split('/');
             const clusterValue = parts[parts.length - 1] + '/clusters';
-            if (localStorageValue === null) {
+            if (lastClusterName === null) {
               localStorage.setItem('notebookValue', clusterValue);
-              localStorageValue = localStorage.getItem('notebookValue') || '';
-              loadDpmsWidget(localStorageValue || '');
-            } else if (localStorageValue !== clusterValue) {
+              lastClusterName = localStorage.getItem('notebookValue') || '';
+              loadDpmsWidget(lastClusterName || '');
+            } else if (lastClusterName !== clusterValue) {
               localStorage.setItem('notebookValue', clusterValue);
-              localStorageValue = localStorage.getItem('notebookValue') || '';
-              loadDpmsWidget(localStorageValue || '');
+              lastClusterName = localStorage.getItem('notebookValue') || '';
+              loadDpmsWidget(lastClusterName || '');
             }
           } else if (
             kernelSpec?.resources.endpointParentResource.includes('/sessions')
           ) {
             const parts = kernelSpec?.name.split('-');
             const sessionValue = parts.slice(1).join('-') + '/sessions';
-            if (localStorageValue === null) {
+            if (lastClusterName === null) {
               localStorage.setItem('notebookValue', sessionValue);
-              localStorageValue = localStorage.getItem('notebookValue') || '';
-              loadDpmsWidget(localStorageValue || '');
-            } else if (localStorageValue !== sessionValue) {
+              lastClusterName = localStorage.getItem('notebookValue') || '';
+              loadDpmsWidget(lastClusterName || '');
+            } else if (lastClusterName !== sessionValue) {
               localStorage.setItem('notebookValue', sessionValue);
-              localStorageValue = localStorage.getItem('notebookValue') || '';
-              loadDpmsWidget(localStorageValue || '');
+              lastClusterName = localStorage.getItem('notebookValue') || '';
+              loadDpmsWidget(lastClusterName || '');
             }
           }
         } else {
@@ -162,23 +162,23 @@ const extension: JupyterFrontEndPlugin<void> = {
             newValue.title.label === 'Config Setup' ||
             newValue.title.label === 'Clusters' ||
             newValue.title.label === 'Serverless') &&
-          localStorageValue !== ''
+          lastClusterName !== ''
         ) {
-          localStorage.setItem('oldNotebookValue', localStorageValue || '');
+          localStorage.setItem('oldNotebookValue', lastClusterName || '');
           localStorage.removeItem('notebookValue');
-          localStorageValue = '';
+          lastClusterName = '';
           loadDpmsWidget('');
         } else {
           if (
-            localStorageValue === '' &&
+            lastClusterName === '' &&
             newValue.title.label !== 'Launcher' &&
             newValue.title.label !== 'Config Setup' &&
             newValue.title.label !== 'Clusters' &&
             newValue.title.label !== 'Serverless'
           ) {
             let oldNotebook = localStorage.getItem('oldNotebookValue');
             localStorage.setItem('notebookValue', oldNotebook || '');
-            localStorageValue = localStorage.getItem('notebookValue') || '';
+            lastClusterName = localStorage.getItem('notebookValue') || '';
             loadDpmsWidget(oldNotebook || '');
           }
         }