From bc1bb759c94aaa14647e95f8c77d0ff26fea23d2 Mon Sep 17 00:00:00 2001
From: Nitin Garg <gargnitin@google.com>
Date: Tue, 13 Aug 2024 20:09:39 +0000
Subject: [PATCH] add default gcsfuseMountOptions in workloads config

---
 .../scripts/testing_on_gke/examples/workloads.json  | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/perfmetrics/scripts/testing_on_gke/examples/workloads.json b/perfmetrics/scripts/testing_on_gke/examples/workloads.json
index e2ab942b4d..ee23487a2c 100644
--- a/perfmetrics/scripts/testing_on_gke/examples/workloads.json
+++ b/perfmetrics/scripts/testing_on_gke/examples/workloads.json
@@ -6,7 +6,7 @@
       "runOnSSD": true,
       "workloads": [
         {
-          "_description": "This is a dummy fio workload (missing the 'fioWorkload' field), purely standing as a header and does not execute any workload. For it to execute a fio workload, it must have a valid 'fioWorkload' object and a valid 'bucket' attribute.",
+          "_description": "This is a dummy fio workload (missing the 'fioWorkload' field), purely standing as a header and does not execute any workload. For it to execute a fio workload, it must have a valid 'fioWorkload', a valid 'bucket' attribute, and a valid gcsfuseMountOption attribute.",
           "_fioWorkload": {
             "_description": "Every fioWorkload must have fileSize, filesPerThread, numThreads, and blockSize fields. readTypes is an array of string values 'read' and 'randread'. If readTypes is missing, then it defaults to [\"read\",\"randread\"].",
             "fileSize": "64k",
@@ -15,6 +15,7 @@
             "blockSize": "64K",
             "readTypes": ["read","randread"]
           },
+          "gcsfuseMountOptions": "GCSFuse mount-options, in a compact stringified format, to be used for the test scenario gcsfuse-generic. The individual config/cli flag values should be separated by comma. Each cli flag should be of the form <flag>[=<value>], while each config-file flag should be of form <config>[:<subconfig>[:<subsubconfig>[...]]]:<value>. For example, a legal value would be: implicit-dirs,file_mode=777,file-cache:enable-parallel-downloads:true,metadata-cache:ttl-secs:-1 .",
           "bucket":"The bucket must have objects with name Workload.{i}/{j} for every i,j where i:0-{numThreads}-1, j:0-{filesPerThread}-1, and each of these objects must be of size {fileSize}. The buckets gke-* are all in us-central1, are owned by GKE team and are in their GCP project(s)."
         },
         {
@@ -25,6 +26,7 @@
             "blockSize": "64K",
             "readTypes": ["read"]
           },
+          "gcsfuseMountOptions": "implicit-dirs",
           "bucket":"fio-64k-1m-us-west1",
           "_bucket_alt2":"fio-64k-1m-us-central1",
           "_bucket_alt3":"gke-fio-64k-1m"
@@ -37,6 +39,7 @@
             "blockSize": "128K",
             "readTypes": ["read"]
           },
+          "gcsfuseMountOptions": "implicit-dirs",
           "bucket":"fio-128k-1m-us-west1",
           "_bucket_alt2":"fio-128k-1m-us-central1",
           "_bucket_alt3":"gke-fio-128k-1m"
@@ -49,6 +52,7 @@
             "blockSize": "256K",
             "readTypes": ["read","randread"]
           },
+          "gcsfuseMountOptions": "implicit-dirs",
           "bucket":"fio-1mb-1m-us-west1",
           "_bucket_alt2":"fio-1mb-1m-us-central1",
           "_bucket_alt3":"gke-fio-1mb-1m"
@@ -60,6 +64,7 @@
             "numThreads": 50,
             "blockSize": "1M"
           },
+          "gcsfuseMountOptions": "implicit-dirs",
           "bucket":"fio-100mb-50k-us-west1",
           "_bucket_alt2":"fio-100mb-50k-us-central1",
           "_bucket_alt3":"gke-fio-100mb-50k"
@@ -72,6 +77,7 @@
             "numThreads": 100,
             "blockSize": "1M"
           },
+          "gcsfuseMountOptions": "implicit-dirs",
           "bucket":"fio-200gb-1-us-west1",
           "_bucket_alt2":"fio-200gb-1-us-central1",
           "_bucket_alt3":"gke-fio-200gb-1"
@@ -84,6 +90,7 @@
             "recordLength": 102400,
             "batchSizes": [800,128]
           },
+          "gcsfuseMountOptions": "implicit-dirs",
           "bucket":"The bucket must have objects with name 'train/', 'valid/', and train/img_{i}_of_{numFilesTrain}.npz for every i where i:0-{numFilesTrain}-1 and each train/img_{i}_of_{numFilesTrain}.npz must be of size {recordLength} bytes. The buckets gke-* are all in us-central1, are owned by GKE team and are in their GCP project(s)."
         },
         {
@@ -92,6 +99,7 @@
             "recordLength": 102400,
             "batchSizes": [800,128]
           },
+          "gcsfuseMountOptions": "implicit-dirs",
           "bucket":"dlio-unet3d-100kb-500k-us-west1",
           "_bucket_alt2":"dlio-unet3d-100kb-500k-us-central1",
           "_bucket_alt3":"gke-dlio-unet3d-100kb-500k"
@@ -102,6 +110,7 @@
             "recordLength": 512000,
             "batchSizes": [800,128]
           },
+          "gcsfuseMountOptions": "implicit-dirs",
           "bucket":"dlio-unet3d-500kb-1m-us-west1",
           "_bucket_alt2":"dlio-unet3d-500kb-1m-us-central1",
           "_bucket_alt3":"gke-dlio-unet3d-500kb-1m"
@@ -112,6 +121,7 @@
             "recordLength": 3145728,
             "batchSizes": [200]
           },
+          "gcsfuseMountOptions": "implicit-dirs",
           "bucket":"dlio-unet3d-3mb-100k-us-west1",
           "_bucket_alt2":"dlio-unet3d-3mb-100k-us-central1",
           "_bucket_alt3":"gke-dlio-unet3d-3mb-100k"
@@ -122,6 +132,7 @@
             "recordLength": 157286400,
             "batchSizes": [4]
           },
+          "gcsfuseMountOptions": "implicit-dirs",
           "bucket":"dlio-unet3d-150mb-5k-us-west1",
           "_bucket_alt2":"dlio-unet3d-150mb-5k-us-central1",
           "_bucket_alt3":"gke-dlio-unet3d-150mb-5k"