From bdeb538a7693a3e1916077bdb313d3730653fc48 Mon Sep 17 00:00:00 2001 From: Nitin Garg Date: Mon, 7 Oct 2024 10:26:27 +0000 Subject: [PATCH] address a self-review comment --- .../scripts/testing_on_gke/examples/utils/gsheet_test.py | 4 ---- perfmetrics/scripts/testing_on_gke/examples/utils/utils.py | 2 +- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/perfmetrics/scripts/testing_on_gke/examples/utils/gsheet_test.py b/perfmetrics/scripts/testing_on_gke/examples/utils/gsheet_test.py index 0f82f18168..f3a65b9702 100644 --- a/perfmetrics/scripts/testing_on_gke/examples/utils/gsheet_test.py +++ b/perfmetrics/scripts/testing_on_gke/examples/utils/gsheet_test.py @@ -27,10 +27,6 @@ class GsheetTest(unittest.TestCase): - # @classmethod - # def setUpClass(self): - # self.project_id = 'gcs-fuse-test' - def test_append_data_to_gsheet(self): _DEFAULT_GSHEET_ID = '1s9DCis6XZ_oHRIFTy0F8yVN93EGA2Koks_pzpCqAIS4' diff --git a/perfmetrics/scripts/testing_on_gke/examples/utils/utils.py b/perfmetrics/scripts/testing_on_gke/examples/utils/utils.py index 140096b689..01215040ee 100644 --- a/perfmetrics/scripts/testing_on_gke/examples/utils/utils.py +++ b/perfmetrics/scripts/testing_on_gke/examples/utils/utils.py @@ -370,7 +370,7 @@ def run_command(command: str) -> int: Returns exit-code which would be non-zero for error. """ result = subprocess.run( - [word for word in command.split(" ") if (word and not str.isspace(word))], + [word for word in command.split(" ") if (word and word.strip())], capture_output=True, text=True, )