Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle undo add to resource. #49

Open
JohanLarsson opened this issue Apr 20, 2018 · 2 comments
Open

Handle undo add to resource. #49

JohanLarsson opened this issue Apr 20, 2018 · 2 comments

Comments

@JohanLarsson
Copy link
Member

JohanLarsson commented Apr 20, 2018

We need to undo the edit of the resx file and the generated file.

@CyrusNajmabadi
Copy link

Take a look at https://github.com/dotnet/roslyn/blob/master/src/VisualStudio/Core/Def/Packaging/PackageInstallerServiceFactory_UndoRedo.cs for how we do this in roslyn for uninstalling a nuget package on 'undo' if you install it with the lightbulb.

@JohanLarsson
Copy link
Member Author

Would adding the resx as an additional document and then do text.WithChanges(...) enable undo?
Guess I can try it.
Alternatively split it up in two code actions, one that adds and one that does the text.WithChanges(...)
Also not sure if it will lead to other bs but guessing the sln is reparsed so that it does not matter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants