Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ComboBox widget for search filters #354

Open
1 task done
Irene-123 opened this issue Aug 24, 2023 · 3 comments
Open
1 task done

ComboBox widget for search filters #354

Irene-123 opened this issue Aug 24, 2023 · 3 comments
Assignees
Labels
enhancement New feature, request, or improvement
Milestone

Comments

@Irene-123
Copy link

Is there an existing issue for this?

  • I have searched the existing issues.

Describe the solution you'd like

Screenshot 2023-08-24 at 10 31 03 PM

Instead of typing, I was wondering if user could select from the existing domains fetched from the backend(over view page) so user could select directly

Is your feature request related to a problem?

This would save time to go back to overview page and to copy the exact domain name and could select from a dropdown box.

I would like to get started with drop-down but if a dropdown feature exists already I would refer it directly. Let me know the checks!

Thanks!

@GyulyVGC
Copy link
Owner

GyulyVGC commented Aug 25, 2023

Hi @Irene-123 and thank you very much for your interest!

Luckily, the latest release of iced introduced a better functionality than a simple dropdown.
The widget you can use is the ComboBox widget and you can find an example about it here: https://github.com/iced-rs/iced/tree/master/examples/combo_box

This is a feature I planned to introduce but I didn't start yet implementing it, so feel free to work on it.

Ideally, I'd like to have this kind of widget for all the text boxes of the inspect page (app protocol, country, domain, ASN).
This will require to store somewhere the collections of available options.
Such collections are not statically defined of course but are modified as new packets arrive.

Let me know if you need additional hints.

@GyulyVGC GyulyVGC added the enhancement New feature, request, or improvement label Aug 25, 2023
@GyulyVGC GyulyVGC added this to the v1.3.0 milestone Aug 25, 2023
@GyulyVGC GyulyVGC changed the title Drop Down Box in search filter ComboBox widget for search filters Aug 25, 2023
@Irene-123
Copy link
Author

I'm facing some issues in understanding the code, is there a discord channel or somewhere I can ask silly doubts? : P

@GyulyVGC
Copy link
Owner

Here's their Discord: https://discord.com/invite/3xZJ65GAhd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, request, or improvement
Projects
None yet
Development

No branches or pull requests

2 participants