This repository has been archived by the owner on Feb 1, 2022. It is now read-only.
feat(app): clicking the HPI logo opens hpi.de #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasWanke
changed the title
MarcelGarus
suggested changes
Oct 15, 2019
MarcelGarus
approved these changes
Oct 15, 2019
MarcelGarus
suggested changes
Oct 15, 2019
There was a problem hiding this comment.
- We shouldn't display Material ink wells when clicking on the logo. So, instead of using an
InkWell, aGestureDetectormight be sufficient. - On the dashboard, we shouldn't detect taps on the whole header, just on the logo.
- On the dashboard, the logo should align with the carousel thingies below.
|
This feature might be confusing if one accidentally activates the button. Maybe an alert with confirmation helps :) |
|
@ctiedt An |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #88
Checklist
Changes
The HPI logos on the dashboard and in the bottom drawer are now buttons that lead to hpi.de.
This branch also includes minor changes to the layout of the bottom drawer to make the HPI logo and settings button more centered.