Process termination in game engine

[rlee287]

Currently processes are forcefully terminated at the end of the game.

Halite-III/game_engine/networking/unix/UnixConnection.cpp

Lines 89 to 91 in 7b7deb7

	UnixConnection::~UnixConnection() noexcept {
	kill(-process, SIGKILL);
	}

Halite-III/game_engine/networking/win32/WinConnection.cpp

Lines 99 to 110 in 7b7deb7

	WinConnection::~WinConnection() noexcept {
	if (read_pipe != INVALID_HANDLE_VALUE) {
	CloseHandle(read_pipe);
	}
	if (write_pipe != INVALID_HANDLE_VALUE) {
	CloseHandle(write_pipe);
	}
	if (process != INVALID_HANDLE_VALUE) {
	TerminateProcess(process, 0);
	CloseHandle(process);
	}
	}

The use of SIGKILL inside UnixConnetion.cpp forcibly shuts down the process without giving it a chance to clean up. Thus, atexit handlers, such as the ShutdownHooks inside Log.java of the Java kit, do not have a chance to run. While I am not as familiar with process signalling on Windows, this article form Dr. Dobbs suggests that TerminateProcess in WinConnection.cpp is equally dangerous.

My suggestion would be using a gentler process of sending SIGTERM (and its Windows equivalent) to give the process a chance to clean up, and then using forcible termination after a short delay if the process hasn't exited by then. This allows higher level languages to perform internal cleanup operations and would also allow users to write their own cleanup functions, e.g. to flush log files.